Remove unused function secrets merge behavior - #12026
Open
sarah (satvu) wants to merge 2 commits into
Open
sarah (satvu) wants to merge 2 commits into
sarah (satvu) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
sarah (satvu)
requested review from
Mathew Charles (mathewc)
and
a lite review from Copilot
September 16, 2026 21:49
sarah (satvu)
marked this pull request as ready for review
September 16, 2026 21:50
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Update the stale coldstart.jittrace reference to the removed overload.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Removes the unused merged parameter and host/function secret merge behavior, updating implementations and tests.
Changes:
- Simplifies
GetFunctionSecretsAsync. - Updates mocks, callers, and test implementations.
- Removes merge-specific test coverage.
File summaries
| File | Summary |
|---|---|
test/WebJobs.Script.Tests/Security/SecretManagerTests.cs |
Updates secret manager tests. |
test/WebJobs.Script.Tests/Managment/WebFunctionsManagerTests.cs |
Updates test callers. |
test/WebJobs.Script.Tests/Controllers/Admin/KeysControllerTests.cs |
Updates key controller tests. |
test/WebJobs.Script.Tests.Shared/TestSecretManager.cs |
Updates the test secret manager. |
test/WebJobs.Script.Tests.Integration/Management/FunctionsSyncManagerTests.cs |
Updates integration tests. |
test/WebJobs.Script.Tests.Integration/Controllers/Keys/KeyManagementFixture.cs |
Updates key management fixtures. |
test/WebJobs.Script.Tests.Integration/Controllers/Keys/GetFunctionKeysScenario.cs |
Updates function key scenarios. |
src/WebJobs.Script.WebHost/Security/KeyManagement/SecretManager.cs |
Removes merge behavior and parameter. |
src/WebJobs.Script.WebHost/Security/KeyManagement/ISecretManager.cs |
Simplifies the interface contract. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
sarah (satvu)
requested review from
Elias Lopez (eliaslopezgt),
Pragna Gopa (pragnagopa) and
Varad Meru (vrdmr)
as code owners
September 16, 2026 23:19
Mathew Charles (mathewc)
approved these changes
Sep 21, 2026
Member
Author
|
Waiting for #11722 to go in first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Resolves #11996
Summary
Removes the unused
mergedparameter fromISecretManager.GetFunctionSecretsAsyncand deletes the associated host/function key merge behavior.The
merged: truepath had no production callers and could throw anArgumentExceptionwhen function-scoped and host-scoped keys differed only by casing. Tests, mocks, and test implementations have been updated to use the simplified method signature, and the merge-specific test has been removed.This is not a customer-facing breaking change.
ISecretManageris an internal product library that is not consumed directly by customers, and the only caller of the merge behavior was removed previously.Validation
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.md