fix: restore FIPS-capable runtime base for agent images - #1353
Merged
Conversation
The hub-agent, member-agent and refresh-token binaries are built with
CGO_ENABLED=1 GOEXPERIMENT=systemcrypto. That backend dlopen()s libcrypto
from the runtime image and, on a node with /proc/sys/crypto/fips_enabled=1,
calls SetFIPS(true), which requires a loadable FIPS provider in the image.
Azure Linux distroless ships one (symcryptprovider.so in /usr/lib/ossl-modules).
Debian-based gcr.io/distroless/base ships libcrypto.so.3 with no ossl-modules
directory at all, so the call fails and the process panics before main():
panic: opensslcrypto: FIPS mode requested (system FIPS mode) but not
available: OpenSSL 3.5.6 7 Apr 2026
crypto/internal/backend.init.0()
/usr/local/go/src/crypto/internal/backend/openssl_linux.go:39 +0x109
The gcr.io base arrived via the #1338 backport of upstream #745 and shipped
in v0.18.14, crash-looping every hub cluster scheduled onto a FIPS-enabled
node (exit 2, CrashLoopBackOff) and taking Scenario_Fleet_Hubful with it.
crd-installer was never switched and stayed healthy.
Restore mcr.microsoft.com/azurelinux/distroless/base:3.0. It is a real
multi-arch manifest list (linux/amd64 + linux/arm64), so the multi-platform
buildx from #745 and the cross-compiling builder from #858 are unaffected --
only the final FROM changes.
Verified: all three images build for linux/amd64,linux/arm64; the resulting
hub-agent starts normally on both architectures with FIPS forced on, where
the v0.18.14 image panics with exit 2.
Copilot started reviewing on behalf of
Yetkin Timocin (ytimocin)
September 10, 2026 21:18
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused runtime-base correction is consistent across all affected images and supported by multi-architecture FIPS validation.
Pull request overview
Restores FIPS-capable Azure Linux runtime images for systemcrypto-enabled agent binaries.
Changes:
- Replaces Debian distroless with Azure Linux distroless.
- Documents the runtime FIPS-provider requirement.
File summaries
| File | Description |
|---|---|
docker/hub-agent.Dockerfile |
Restores FIPS-capable runtime base. |
docker/member-agent.Dockerfile |
Restores FIPS-capable runtime base. |
docker/refresh-token.Dockerfile |
Restores FIPS-capable runtime base. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Yetkin Timocin (ytimocin)
September 10, 2026 21:28
View session
Yoo Bin Shin (nibooy)
approved these changes
Sep 10, 2026
Chen Yu (michaelawyu)
approved these changes
Sep 11, 2026
Chen Yu (michaelawyu)
left a comment
Contributor
There was a problem hiding this comment.
LGTM ;) We probably need to do a renaming as Stephane suggested to guard these three files in rebases, but it does not have to be done in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
The hub-agent, member-agent and refresh-token binaries build with
CGO_ENABLED=1 GOEXPERIMENT=systemcrypto. That backenddlopen()s libcrypto from the runtime image and, on a node with/proc/sys/crypto/fips_enabled=1, callsSetFIPS(true)— which needs a loadable FIPS provider in that image.Azure Linux distroless ships one (
symcryptprovider.soin/usr/lib/ossl-modules). Debian-basedgcr.io/distroless/baseshipslibcrypto.so.3with noossl-modulesdirectory at all, so the call fails and the process panics beforemain():The
gcr.iobase arrived via the #1338 backport of upstream kubefleet#745 and shipped in v0.18.14, crash-looping (exit 2,CrashLoopBackOff) every hub cluster scheduled onto a FIPS-enabled node and takingScenario_Fleet_Hubfulwith it.crd-installerwas never switched and stayed healthy.This restores
mcr.microsoft.com/azurelinux/distroless/base:3.0. Only the finalFROMchanges —:3.0is a real multi-arch manifest list (linux/amd64 + linux/arm64), so the multi-platform buildx from #745 and the cross-compiling builder from #858 are unaffected.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
linux/amd64,linux/arm64— amd64 through the cross toolchain, arm64 native, no QEMU.hubagentstarts normally on both architectures with FIPS forced on; the v0.18.14 image panics with exit 2 under the same conditions.Reproducible in seconds, no FIPS hardware needed:
Special notes for your reviewer
Upstream kubefleet uses
gcr.io/distrolesshere and always has, so this stays an Azure/fleet-only delta that future backports will try to overwrite — the comment on theFROMline records why. Upstream carries the same latent crash (systemcrypto on the providerless base since kubefleet#261); it goes unnoticed there only because FIPS is requested by the node, not the project.