[openApiDiff.ts] Replace exec with execFile - #370
Merged
Conversation
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
|
|
||
| import * as asyncFs from "@ts-common/fs" | ||
| import * as jsonParser from "@ts-common/json-parser" |
Member
Author
There was a problem hiding this comment.
unrelated unused import
Mike Harder (mikeharder)
marked this pull request as ready for review
August 30, 2025 01:27
Mike Harder (mikeharder)
requested review from
Ray Chen (raych1) and
Scott Beddall (scbedd)
August 30, 2025 01:28
Mike Harder (mikeharder)
changed the title
exec with execFileexec with execFile
Mike Harder (mikeharder)
moved this from 🤔 Triage
to 🔬 Dev in PR
in Azure SDK EngSys 🚀🌒🧑🚀
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the use of child_process.exec() with execFile() to improve security by eliminating shell command injection vulnerabilities. The change removes the need for manual shell argument escaping and simplifies command execution.
- Replaced
execwithexecFilein openApiDiff.ts for safer command execution - Removed shell-quote dependency and related escaping logic
- Restructured command building to use argument arrays instead of shell strings
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lib/validators/openApiDiff.ts | Replaced exec with execFile, removed shell escaping functions, restructured command building |
| src/test/shellEscapingTest.ts | Removed entire test file as shell escaping is no longer needed |
| package.json | Removed shell-quote dependency and its type definitions |
| CHANGELOG.md | Added entry documenting the change to execFile |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Ray Chen (raych1)
approved these changes
Sep 2, 2025
Wes Haggard (weshaggard)
moved this from 🔬 Dev in PR
to 🎊 Closed
in Azure SDK EngSys 🚀🌒🧑🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.