Skip to content

[PATCH] [tests]: Enable production Sign-in V2 E2E tests - #3115

Open
Sergei Demchenko (antrix1989) wants to merge 4 commits into
devfrom
antrix1989-enable-sign-in-v2-tests
Open

Sergei Demchenko (antrix1989) wants to merge 4 commits into
devfrom
antrix1989-enable-sign-in-v2-tests

Conversation

@antrix1989

Copy link
Copy Markdown
Contributor

PR Checklist (must be completed before review)

  • All tests pass locally
  • PR size is <= 500 LOC per PR Size Check policy
  • PR is independently mergeable (no hidden dependencies)
  • Appropriate reviewers are assigned
  • PR reviewed by code owner (required if Copilot-generated)
  • SME or Senior IC assigned where required

PR Title Format

Required Format: [Keyword1] [Keyword2]: Description

This PR uses [PATCH] [tests] as specified by the repository template.

Proposed changes

CIAM V2 APIs are now available in production, as confirmed by the requester, so the blanket "requires a test slice" skips are obsolete. Remove only the redundant setUpWithError overrides from three Sign-in V2 E2E suites; inherited setup remains in effect.

This makes exactly 14 existing test methods eligible to run:

Suite Newly eligible tests
MSALNativeAuthSignInUsernameV2EndToEndTests (OTP) 5
MSALNativeAuthSignInUsernameAndPasswordV2EndToEndTests 7
MSALNativeAuthSignInWithMFAV2EndToEndTests 2

The following existing method-level skips remain unchanged and are explicitly outside this PR's scope:

  • test_signInCustomSubdomainLongInSuccess (authority format)
  • test_signInCustomSubdomainShortInSuccess (authority format)
  • test_signInAuthenticationContextClaim_mfaFlowIsTriggeredAndAccessTokenContainsClaims (claims)

Preserve all runtime OTP-throttling skips, test bodies, helpers, assertions (including commented username assertions), and fixture configuration. No SSPR, sign-up, production SDK, test-plan, or submodule-pointer changes. The diff is three files and 15 deleted lines; no SDK changelog change is needed for this test-only enablement.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Previously skipped tests will exercise production services when the E2E suites are run; runtime fixture/service failures remain possible and OTP-throttling skips remain active.

Additional information

Static verification completed against latest dev, confirmed via GitHub API at de46a5b76a4a3540c9998a76ee21809a39e10f76:

  • Verified exact eligibility: 17 methods minus the 3 retained explicit skips = 14 newly eligible methods (5 OTP + 7 password + 2 MFA).
  • Verified every changed file is byte-for-byte equivalent to its baseline after removing only its obsolete setup override. All 10 OTP-throttling helper calls across the three files remain unchanged, as do all unrelated skips and fixtures.
  • Verified all three source files are included in both iOS and macOS Native Auth E2E targets; both schemes reference the existing unfiltered E2E test plans, with no selected/skipped-test exclusions.
  • git diff --check passed; only the three approved test files changed.

Per the explicit execution constraint, no live E2E tests, Xcode builds/tests, simulator commands, or secret retrieval were performed. The local-test checklist remains unchecked. This PR does not claim production tests pass.

The centralized PR-title workflow referenced at the Broker repository's main ref returned HTTP 404 during inspection; the title follows this repository's checked-in PR template. No workflow changes were made.

Remove obsolete blanket test-slice skips from three Sign-in V2 suites, enabling 5 OTP, 7 password, and 2 MFA tests. Preserve authority-format, claims, and runtime OTP-throttling skips.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 26, 2026 00:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved issues were identified that would block approval.

Review effort: Lite
Findings: None

What changed in this PR

Removes obsolete suite-level skips so production Sign-in V2 E2E tests can execute.

Changes:

  • Enables three Sign-in V2 E2E suites.
  • Preserves inherited setup and method-level skips.
File Description
MSAL/​test/​integration/​native_auth/​end_to_end/​sign_in/​MSALNativeAuthSignInUsernameV2EndToEndTests.swift Updated as part of this pull request.
MSAL/​test/​integration/​native_auth/​end_to_end/​sign_in/​MSALNativeAuthSignInUsernameAndPasswordV2EndToEndTests.swift Updated as part of this pull request.
MSAL/​test/​integration/​native_auth/​end_to_end/​mfa/​MSALNativeAuthSignInWithMFAV2EndToEndTests.swift Updated as part of this pull request.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI lite review requested due to automatic review settings September 29, 2026 17:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved issues were identified that would block approval.

Review effort: Lite
Findings: None

Copilot AI lite review requested due to automatic review settings October 2, 2026 22:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 1 High severity · 1 Medium severity · 1 Low severity

Open (3)

Copilot AI lite review requested due to automatic review settings October 5, 2026 02:21
@antrix1989
Sergei Demchenko (antrix1989) force-pushed the antrix1989-enable-sign-in-v2-tests branch from 663523a to 8c33320 Compare October 5, 2026 02:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Remove the MFA skip and revert unrelated changes while preserving the username assertion.

Review effort: Lite
Findings: 1 Low severity

Open (1)
Resolved since last review (3)

Copilot AI lite review requested due to automatic review settings October 7, 2026 00:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Remove the MFA suite skip and revert unrelated comment edits.

Review effort: Lite
Findings: None

Resolved since last review (1)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants