Repository navigation
[PATCH] [tests]: Enable production Sign-in V2 E2E tests - #3115
Open
Sergei Demchenko (antrix1989) wants to merge 4 commits into
Open
Sergei Demchenko (antrix1989) wants to merge 4 commits into
Sergei Demchenko (antrix1989) wants to merge 4 commits into
Conversation
Remove obsolete blanket test-slice skips from three Sign-in V2 suites, enabling 5 OTP, 7 password, and 2 MFA tests. Preserve authority-format, claims, and runtime OTP-throttling skips. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sergei Demchenko (antrix1989)
requested a review
from a team
as a code owner
September 26, 2026 00:15
Copilot started reviewing on behalf of
Sergei Demchenko (antrix1989)
September 26, 2026 00:15
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified that would block approval.
Review effort: Lite
Findings: None
What changed in this PR
Removes obsolete suite-level skips so production Sign-in V2 E2E tests can execute.
Changes:
- Enables three Sign-in V2 E2E suites.
- Preserves inherited setup and method-level skips.
| File | Description |
|---|---|
| MSAL/test/integration/native_auth/end_to_end/sign_in/MSALNativeAuthSignInUsernameV2EndToEndTests.swift | Updated as part of this pull request. |
| MSAL/test/integration/native_auth/end_to_end/sign_in/MSALNativeAuthSignInUsernameAndPasswordV2EndToEndTests.swift | Updated as part of this pull request. |
| MSAL/test/integration/native_auth/end_to_end/mfa/MSALNativeAuthSignInWithMFAV2EndToEndTests.swift | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Sergei Demchenko (antrix1989)
September 29, 2026 17:44
View session
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 1
Open (3)
The PR description says the redundant suite-widesetUpWithErrorskips are removed from three… · New This change comments out an assertion that was previously active. The PR description states it… · New The indentation and trailing whitespace in this method are inconsistent with the surrounding Swift… · New
Copilot started reviewing on behalf of
Sergei Demchenko (antrix1989)
October 2, 2026 23:01
View session
Sergei Demchenko (antrix1989)
force-pushed
the
antrix1989-enable-sign-in-v2-tests
branch
from
October 5, 2026 02:21
663523a to
8c33320
Compare
Copilot started reviewing on behalf of
Sergei Demchenko (antrix1989)
October 5, 2026 02:21
View session
Copilot started reviewing on behalf of
Sergei Demchenko (antrix1989)
October 7, 2026 00:52
View session
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Checklist (must be completed before review)
PR Title Format
Required Format:
[Keyword1] [Keyword2]: DescriptionThis PR uses
[PATCH] [tests]as specified by the repository template.Proposed changes
CIAM V2 APIs are now available in production, as confirmed by the requester, so the blanket "requires a test slice" skips are obsolete. Remove only the redundant
setUpWithErroroverrides from three Sign-in V2 E2E suites; inherited setup remains in effect.This makes exactly 14 existing test methods eligible to run:
MSALNativeAuthSignInUsernameV2EndToEndTests(OTP)MSALNativeAuthSignInUsernameAndPasswordV2EndToEndTestsMSALNativeAuthSignInWithMFAV2EndToEndTestsThe following existing method-level skips remain unchanged and are explicitly outside this PR's scope:
test_signInCustomSubdomainLongInSuccess(authority format)test_signInCustomSubdomainShortInSuccess(authority format)test_signInAuthenticationContextClaim_mfaFlowIsTriggeredAndAccessTokenContainsClaims(claims)Preserve all runtime OTP-throttling skips, test bodies, helpers, assertions (including commented username assertions), and fixture configuration. No SSPR, sign-up, production SDK, test-plan, or submodule-pointer changes. The diff is three files and 15 deleted lines; no SDK changelog change is needed for this test-only enablement.
Type of change
Risk
Previously skipped tests will exercise production services when the E2E suites are run; runtime fixture/service failures remain possible and OTP-throttling skips remain active.
Additional information
Static verification completed against latest
dev, confirmed via GitHub API atde46a5b76a4a3540c9998a76ee21809a39e10f76:git diff --checkpassed; only the three approved test files changed.Per the explicit execution constraint, no live E2E tests, Xcode builds/tests, simulator commands, or secret retrieval were performed. The local-test checklist remains unchecked. This PR does not claim production tests pass.
The centralized PR-title workflow referenced at the Broker repository's
mainref returned HTTP 404 during inspection; the title follows this repository's checked-in PR template. No workflow changes were made.