Repository navigation
Propagation - #20
Merged
Merged
Propagation#20
Conversation
propagation_checks() applies the rules get_candidates() uses and reports the rules each package fails; get_candidates() now keeps the packages that pass, with the same results as before. BBS commits come from bbs_status() for every package type instead of only software. propagation_status() combines the source and binary targets for a branch, with binaries only for software as Bioconductor distributes, and write_comparisons() saves it. propagation_table() and propagation_summary_table() show it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Remove the old propagation vignette, which the propagation pages replace, and BiocPkgTools and kableExtra, which nothing uses anymore. Drop Windows arm64, which Bioconductor does not distribute. Yes links to the file that would be harvested and No to the R Universe job that failed, from propagation_checks()'s new failure_url. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Binaries without compiled code work on both Mac architectures and were linked to big-sur-x86_64 for arm64 too. For arm64, get_candidates() and propagation_checks() now use sonoma-arm64, where R Universe serves the same file. Also keep get_jobs() artifacts character when a universe has no source jobs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
propagation_checks() also returns vignettes_check and linux_check, the results its rules use, and get_candidates() drops the rule columns, so its output has the same columns as before. Tests that read vignettes_check were otherwise passing without checking anything. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nothing but tests read vignettes_check or linux_check from get_candidates(), so it no longer returns them; propagation_checks() still does. The vignette tests check the source build through propagation_checks(), and a test for a column get_candidates() never had is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The rule results, vignettes_check, linux_check, BBS_commit, and Deprecated were only read by tests, so propagation_checks() keeps them internal and get_candidates() returns only the jobs that pass. Reports still show deprecation and the BBS commit from bbs_status(). Tests now check candidates against R Universe's source build results and BBS commits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rebuilt from the original get_candidates(), with each criterion as its own block controlled by an argument and source criteria inline. Results are the same as before. propagation_checks() is not yet removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
get_candidates() is the only place with propagation criteria. A package propagates to a target if get_candidates() selects it; Yes links to the file and No to the target's R Universe job. source_jobs is created once. For macOS x86_64, Rbec now propagates as get_candidates() and harvest.R already had it; the page had used its failed arm64 job instead of its passing x86_64 binary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
get_candidates() stops if arch is missing for windows or macosx, and checks that a binary passed R CMD check and built whether or not commit is on, so commit = FALSE only drops the commit criterion. filter_by_arch() uses a universal binary for the other architecture only for packages without a job for that architecture; a compiled package's failed job is not a universal binary. With commit = TRUE the candidates are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.