Repository navigation
fix(connection): show Klipper's error reason after an E-stop reboot - #354
Merged
Merged
Conversation
…and request, info error-only
RobeMartins
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After an E-stop and a reboot, the ConnectionPage now shows the reason Klipper gives instead of a generic error.
Changes
mainWindow: pass theprinter.inforeply to the ConnectionPage (it was dropped at a TODO)ConnectionPage: handleerrorstates with the existing shutdown-reason pipelineCan not update MCU,Command request),Unable to connect, failed MCU reset,MCU Protocol errorPrevious MCU '<name>' shutdown:andmcu '<name>':prefixes so the map keys don't depend on the MCU nameMotivation
The MCU stays shut down across a host reboot, so Klipper boots into
error. The subscription only exists once Klipper isready, soprinter.infois the only source of the message, and its reply was being dropped. The approach follows KlipperScreenstate_errorand FluiddonServerInfo, which prefers the printer.info message.Tests
TestErrorMessagesintests/widgets/test_connection_page.pyFuture work