feat(witness): resolve file values against program-declared types#371
Open
KyrylR wants to merge 2 commits into
Open
feat(witness): resolve file values against program-declared types#371KyrylR wants to merge 2 commits into
KyrylR wants to merge 2 commits into
Conversation
LesterEvSe
approved these changes
Jul 14, 2026
LesterEvSe
left a comment
LesterEvSe
left a comment
Collaborator
There was a problem hiding this comment.
ACK 3fe6c4a; tested locally with just check and just check_fuzz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I started implementing enums like in Rust (nominative) I struggled a lot with the fact types are in the .args and .wit files
Because we have access to the program and actual compiler instead of providing types twice we can just rely on the program itself
apoelstra if there was a security reason pls let me know