Repository navigation
Fix/sum identity order - #33
Merged
Merged
Conversation
sumPubKeys and _sumPrivkeys aborted as soon as tiny-secp256k1 returned null for the point at infinity / zero scalar, so [A, -A, A] failed while [A, A, -A] succeeded. Continue through intermediate identity and only fail if the final sum is identity. Fixes #30
The pubkey-only vector left createTransaction [A,-A,A] and the zero-sum failure boundary unguarded.
GladosBlueWallet
approved these changes
Sep 14, 2026
GladosBlueWallet
left a comment
GladosBlueWallet
left a comment
There was a problem hiding this comment.
Fixes #30 by teaching _sumPrivkeys and sumPubKeys that intermediate zero scalars and point-at-infinity are additive identity—not failure states. Only a final zero sum throws or returns null. The implementation matches the stated intent; I am almost disappointed there is nothing to eviscerate.
Tests use real #30 vectors: pubkey order-independence, final-infinity null, createTransaction order-independence, and zero-sum throws. Proper test subjects. Continue the experiment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.