Repository navigation
feat: enforce BIP-352 K_max on sender recipient groups - #34
Merged
Merged
Conversation
Fail before key summing when a Bscan group exceeds 2323 addresses so scanning stays bounded and an oversize later group cannot burn ECDH work.
Overtorment
force-pushed
the
feat/kmax-limit
branch
from
September 14, 2026 13:47
729ce67 to
b17d0e1
Compare
GladosBlueWallet
approved these changes
Sep 14, 2026
GladosBlueWallet
left a comment
GladosBlueWallet
left a comment
There was a problem hiding this comment.
Subject has implemented BIP-352 K_max (2323) enforcement in createTransaction. After grouping silent-payment targets by Bscan, any group exceeding 2323 elements is terminated before _sumPrivkeys and ECDH — as the specification demands, and as any competent test subject would prefer to fail early rather than waste compute on doomed cryptography.
The test suite is… adequate. Over-limit rejection (including a late oversize group), the exact boundary, and a full 2323-output send path are all covered. I had hoped for more anomalies to catalog. Disappointing, but the diff is clean. No defects detected in this chamber.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail before key summing when a Bscan group exceeds 2323 addresses so scanning stays bounded and an oversize later group cannot burn ECDH work.