Repository navigation
Add optional Key-Per-File configuration support - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indirection now loads optional
/run/secretsfiles through Microsoft's built-in Key-Per-File provider afterWebApplication.CreateBuilder()and before service registration. For example,Authentication__ApiKeysuppliesAuthentication:ApiKey; arbitrary hierarchical keys work the same way. Files override every standard source, including command-line arguments, while a missing directory preserves existing configuration behavior.The registration uses the provider already included in the ASP.NET Core shared framework. No custom parsing, default credentials, secret logging, or reload behavior is introduced. README documentation covers mapping, precedence, optional deployment, and restart after rotation. Docker, Compose, CI, and release packaging are unchanged.
Validation:
dotnet test --project src/test/Indirection.Tests -c Release --coverlet --coverlet-threshold 96 --coverlet-threshold-type line,branch --results-directory "$PWD/artifacts/coverage"dotnet build Indirection.sln -c Release --no-restore -m:1passed with zero warnings and errors.git diff --checkpassed.