Repository navigation
bb2-5332 add logging - #1786
bb2-5332 add logging#1786BenColeCode wants to merge 7 commits into
Conversation
…/CMSgov/bluebutton-web-server into bencolecode/bb2-5332-add-logging
| verify=self.verify_ssl_internal, | ||
| ) | ||
|
|
||
| logger.info({'Status of Request':response.status_code}) |
There was a problem hiding this comment.
Let's update this so it aligns with how other logs output 'response_code', and also some indication that it's the status_code for the relationships retrieval call
JamesDemeryNava
left a comment
There was a problem hiding this comment.
Log appears as expected, let's add some more detail and conform with logging patterns.
Ok! I had taken that from apps/fhir/bluebutton/utils. I will look for other instances of status logging. |
|
Ok, I have added to the dict obj to match other logging in the same file, while still printing the status code roughly the same as how we do it in fhir. |
| verify=self.verify_ssl_internal, | ||
| ) | ||
|
|
||
| log_dict = {'type': 'Authentication:relationships_retrieval', 'status': response.status_code} |
There was a problem hiding this comment.
This never actually gets logged. Need to add logger.info(log_dict), and change the key to response_code to match other logs.
JamesDemeryNava
left a comment
There was a problem hiding this comment.
Log is not output
JIRA Ticket:
BB2-5332
What Does This PR Do?
Adds status code logging to relationships endpoint
What Should Reviewers Watch For?
Does this log the status of requests?
If you're reviewing this PR, please check for these things in particular:
Validation
make a request to the endpoint and check the logs
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)