Skip to content

Add waffle switch for enabling/disabling asymmetric auth - #1788

Merged
ryan-morosa merged 2 commits into
masterfrom
ryan-morosa/add-waffle-switch-for-blocking-asymm-auth
Oct 30, 2026
Merged

ryan-morosa merged 2 commits into
masterfrom
ryan-morosa/add-waffle-switch-for-blocking-asymm-auth

Conversation

@ryan-morosa

@ryan-morosa ryan-morosa commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

JIRA Ticket:
N/A

What Does This PR Do?

This PR adds a waffle switch for controlling whether or not asymmetric auth can be allowed or disallowed. It's based upon the conversation from slack here.

What Should Reviewers Watch For?

  • Does the name for the waffle switch look good?
  • Does the error message look good?

If you're reviewing this PR, please check for these things in particular:

Validation

  • Added an integration test that tests it both with the waffle switch active and the waffle switch not active - I think this is good enough validation but let me know otherwise.

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

@ryan-morosa
ryan-morosa marked this pull request as ready for review October 29, 2026 21:28
@ryan-morosa ryan-morosa changed the title Add waffle switch for allowing and disallowing asymmetric auth Add waffle switch for enabling/disabling asymmetric auth Oct 29, 2026
@jimmyfagan jimmyfagan self-assigned this Oct 29, 2026

@jimmyfagan jimmyfagan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's touch base tomorrow about getting these recent waffle switches sorted out prior to the next deployment!

@ryan-morosa
ryan-morosa merged commit 97b1c65 into master Oct 30, 2026
14 checks passed
@ryan-morosa
ryan-morosa deleted the ryan-morosa/add-waffle-switch-for-blocking-asymm-auth branch October 30, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants