Repository navigation
Conversation
Merged
Pavithra-aa-Anand
requested review from
Pavithra-aa-Anand,
Renu-Priya411 and
shubhamshahaBMW
October 30, 2026 11:48
Collaborator
|
Rebase the PR |
The progress output was printed with qDebug() in the GUI as well, where QDltFile::updateIndex() runs on every live-connection update and floods the log with "CI: 97 %" lines.
borgsten
force-pushed
the
bugfix/silence_noicy_debug_log
branch
from
November 1, 2026 11:44
b52fec1 to
0b642e0
Compare
Contributor
Author
Done! |
Pavithra-aa-Anand
requested changes
Nov 2, 2026
| while(true) | ||
| { | ||
| // Progress for command line conversions; in the GUI this runs on | ||
| // every update of a live connection. |
Collaborator
There was a problem hiding this comment.
Make it as a single line comment.
| if( (file_size>0) && ((pos*100/file_size)>=progressNextCmdOutput)) | ||
| { | ||
| qDebug() << "CI:" << pos*100/file_size << "%"; | ||
| if(QDltOptManager::getInstance()->isCommandlineMode()) |
Collaborator
There was a problem hiding this comment.
This also suppresses indexing progress in dlt-commander. Commander uses its own option parser, so QDltOptManager::isCommandlineMode() remains false even during CLI conversion. Could we make this logging policy explicit for callers, so GUI indexing stays quiet while Commander retains its CI: progress?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CI: X %progress line seems intended for command line conversions, but it is alsologged during live sessions in the GUI, where
QDltFile::updateIndex()runs on everyupdate. This results in a lot of noise in the terminal, or in the journal when launched
from a desktop launcher.
Example:
This could also be silenced with
add_compile_definitions(QT_NO_DEBUG_OUTPUT)orQT_LOGGING_RULES="*.debug=false", but that also hides the output ofdlt-viewer --help,which is written with
qDebug()as well.Instead, the progress line in
QDltFile::updateIndex()andDltFileIndexer::index()isnow only printed in command line mode.