fix: make diff snapshot export cancellable#7253
Conversation
WalkthroughIn ChangesAsync yield in diff-export stream drain loop
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
2302ffd to
8f832d2
Compare
8f832d2 to
1578bab
Compare
Summary of changes
Our
ChainStreamimplementation never returnsPoll::Pendingso we need some yield point for tokio to decide whether to discard the task. An alternative fix is implemented in #7254Tested with #7252
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit