Prepare release 0.0.1 - #58
Merged
Merged
Conversation
Record what 0.0.1 ships: the chaste-sbml command, the model types, the base classes it copies, the SBML constructs it translates, and the constructs it rejects. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013KTkNQiwhCxyRwTEubEC6k
setuptools deprecated both the `license` table and the license classifier, and warns that builds using them stop being supported after 2027-Feb-18. Move to the PEP 639 spelling before the first release. Building now emits no deprecation warnings, and the wheel carries License-Expression: BSD-3-Clause with the text under dist-info/licenses. SPDX expressions need setuptools >= 77, so the build requirement moves up to match. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013KTkNQiwhCxyRwTEubEC6k
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Resolve the package-name mismatch and inconsistent release tag references before publishing.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Prepares the project for the 0.0.1 PyPI release.
Changes:
- Updates packaging and SPDX license metadata.
- Adds 0.0.1 release notes and known limitations.
File summaries
| File | Summary |
|---|---|
pyproject.toml |
Distribution name remains chaste-sbml, which does not satisfy the requested chaste_codegen_sbml install command. |
CHANGELOG.md |
Release links use v0.0.1, while installation documentation uses 0.0.1; these references must be made consistent. |
Review details
Suppressed comments (1)
CHANGELOG.md:48
- This release link names the tag
v0.0.1, butdoc/installation.mdtells users to install from the0.0.1ref. If the release is created with the tag shown here, both documented install commands fail because Git cannot resolve@0.0.1; use one tag spelling consistently (and update the other reference).
[0.0.1]: https://github.com/Chaste/chaste-sbml/releases/tag/v0.0.1
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: kwabenantim <1944963+kwabenantim@users.noreply.github.com>
This reverts commit aa2f408. The distribution is `chaste-sbml`, matching the repository, the console command and the import package; `chaste-codegen-sbml` was the old name, dropped when the proposed umbrella-merge with chaste-codegen (#6) was abandoned. Renaming the distribution would also publish 0.0.1 under the abandoned name. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013KTkNQiwhCxyRwTEubEC6k
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports #5