Conversation
Add a toggle button in the logs header and an Alt+I keyboard shortcut to collapse or expand the instances (left) panel, giving the log stream more room. It mirrors the existing fullscreen toggle: internal state only, no new public API. The collapse drives --instances-width to 0 with a width transition that honors prefers-reduced-motion, and the button exposes its state through aria-expanded (a11y-expanded). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014a2ePwfEMY6T3ea5UyEmrH
Member
|
Thanks a lot for this @KannarFr, and sorry for the delay. As we discussed, we would rather get a well detailed issue that describes the problem, and let us evaluate the impacts, ask the right questions and find the right solution. That is easier on our side, where we manage the business concerns, the code and its history, and the rest of the roadmap. The problem itself is a real one and we want to solve it: I have opened #1830 to track it, and referenced your proposal there. Closing this PR, the discussion continues in the issue. |
Contributor
|
🔎 The preview has been automatically deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context — a suggestion, not a mandate 🙂
I'm coming at this as a user of
cc-logs-app-runtimein the console, not as a maintainer of this component. On narrower screens the fixed-width Instances panel eats a lot of horizontal space, and most of the time I just want to read the log stream. So this is a small quality-of-life proposal — very happy for you to take it, tweak it, or close it if it doesn't fit your plans for the component.What it does
Adds a way to collapse/expand the left Instances panel so the log stream can use the full width:
sidebar-fold/sidebar-unfoldRemix icons.Alt+I(I = Instances). I checked the existing shortcuts incc-logs(Ctrl+C,Ctrl+A, arrows,Home/End,Escape,Space/Enter) —Alt+letter was a free namespace, so no collision.How it's built (kept minimal + consistent)
_instancesCollapsed), no new public property, no new event — so noevents-mapchange.--instances-widthcustom property to0, so the "no logs / loading" overlays that already center off that variable stay correct for free.aria-expanded(viaa11y-expanded) and a translateda11y-name(EN + FR added), whichcc-buttonalso surfaces as the hovertitle.@media (prefers-reduced-motion).Alt+Ihandler is element-scoped (@keydownon the component root), matching the existing keyboard-handling approach — no new global listeners.event.code === 'KeyI'is used becauseAlt/Optionmutatesevent.keyon some layouts.cc-logsdocuments its keyboard navigation.Checks
Ran the CI-gate pieces locally on the touched files:
eslint,stylelint,components:check-i18n(EN + FR present), andcomponents:events-map-check(up to date — no new events). Happy to add a collapsed-state story and/or therun-visual-testslabel if you'd like that before merging — just say the word.Open questions for you
🤖 Generated with Claude Code