fix: accept a plain number of seconds as a duration - #1164
Merged
Merged
Conversation
|
🔎 The preview has been automatically deleted. |
hsablonniere
approved these changes
Sep 25, 2026
hsablonniere
left a comment
Member
There was a problem hiding this comment.
Looked into whether this could be expressed more declaratively with Zod (a union of duration/date schemas). It's feasible, but the rest of the codebase isn't there yet (still JS, not TypeScript). Once we're fully on TypeScript, moving this kind of parsing/validation logic to Zod schemas will be worth revisiting.
Approving as is.
hsablonniere
force-pushed
the
davlgd-fix-duration-seconds
branch
from
September 25, 2026 09:10
8cbedd7 to
2f7426a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1163
Context
A plain number of seconds passed to
--afteror--beforebecomes an invalid date:clever logsshows no logs without any error.Proposal
parseSimpleDuration()throws when there is no known unit, so the fallback on a number of seconds is reached10xis rejected instead of read as 10 secondsHow to test