Repository navigation
Conversation
Fields adapted for a kernel drop their indices, so the size of an operation on such a field indexed `nothing` inside a broadcast kernel, e.g. in `findmin` of a field on a `TripolarGrid` on the GPU. Size now falls back to the full axes as `axes` already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
xkykai
marked this pull request as ready for review
October 13, 2026 02:46
xkykai
requested review from
giordano and
navidcy
and removed request for
navidcy
October 13, 2026 02:46
Collaborator
Author
|
close as duplicate of #6238! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6237. Fixes the docs build, which has failed since #6228 in
examples/global_wind_driven_gyres.jl:argminof a field on a GPUTripolarGridfailed to compile (InvalidIRError,jl_f_throw_methoderror).size(::AbstractField)usesindices(f), but operations adapted for a kernel see their fields' indices asnothing, soaxes→sizeinside the broadcast kernel offindmin/findmaxindexednothing.sizenow falls back to the full axes throughaxes_indices, asaxesalready does.🤖 Generated with Claude Code