Versions benchmark: master (Docker-free local provider) + TPC-DS UNION DISTINCT#974
Merged
Merged
Conversation
Running the 'master' version installs ClickHouse on the host with the official one-liner (curl https://clickhouse.com/ | sh -- which fetches the master build) and runs the server as a background process out of .local-server, instead of a Docker container. run-version.sh gains a CLIENT_MODE=local path (install/start/revive/detect/sizing without docker); list-versions.sh emits 'master' with the 'local' provider; create.sh uses modern DDL for it; fetch-results.sh keeps it named 'master' (not renamed to its actual_version, which moves); apply-minvers.py and version_key treat 'master' as the newest. run-benchmark.sh already handles it (image 'local' is neither a build recipe nor 'unavailable'). Verified end to end: curl|sh fetches the master binary, the server starts and reports 26.7.1.483, uk loads (31.3M rows), queries time, and data_size comes from system.parts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Four bare UNIONs (queries 14 and 38) become UNION DISTINCT; the 34 UNION ALL are left as is. Semantically identical, but explicit -- older versions reject a bare UNION without union_default_mode set. Regenerated data.generated.js. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #972.
masterversion via a Docker-free local provider: it installs ClickHouse withcurl https://clickhouse.com/ | sh(the master build) and runs the server on the host. run-version.sh gains aCLIENT_MODE=local path; list-versions.sh emits
masterwith thelocalprovider; create.sh uses modern DDL; fetch-results.sh keeps it namedmaster; apply-minvers.py / version_key treat it as newest.UNIONs in TPC-DS (queries 14 and 38) explicit asUNION DISTINCT(older versions reject a bare UNION). Regenerated data.generated.js.