Versions benchmark rework 3#975
Merged
Merged
Conversation
…stop Previously the local provider ran 'nohup ./clickhouse server &' and, on teardown, killed it via a pidfile in .local-server. That could hang: the backgrounded server was not disowned, so the shell blocked in wait at exit, and if .local-server (pidfile/binary) was removed the kill did nothing (the pkill pattern never matched, and a broad one would have hit other servers on the host). Observed a run stuck in do_wait after the benchmark finished. Use ClickHouse's own service management instead: curl|sh -> './clickhouse install -y' -> 'clickhouse start', and 'clickhouse stop' on cleanup. It daemonises itself (nothing for this shell to wait on) and stops cleanly by its own pidfile. Verified the install/start/stop subcommands and flags exist in the master build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
master has no fixed release date (it is the moving dev tip), so run-version.sh's release_date() and fetch-results.sh's reldate() now return the current date for it -- the run day when benchmarked, and the fetch day as a fallback for a run that recorded none. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
First result from the Docker-free local provider: master benchmarked via curl|sh -> clickhouse install/start. 344 queries (4 fail on master: tpch Q5 timeout; tpcds Q5 Variant(Decimal,Float64) sum; tpcds Q14/Q15 need a subquery alias), all 10 datasets loaded, dated by the run day. 201 versions on the page now. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.