Skip to content

[#555] Enforce NFT royalty accounting and transfer invariants - #558

Merged
1nonlypiece merged 2 commits into
Commitlabs-Org:masterfrom
Jagadeeshftw:feat/issue-555-nft-royalty-accounting
Aug 27, 2026
Merged

1nonlypiece merged 2 commits into
Commitlabs-Org:masterfrom
Jagadeeshftw:feat/issue-555-nft-royalty-accounting

Conversation

@Jagadeeshftw

@Jagadeeshftw Jagadeeshftw commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add seller-authorized royalty configuration with a 10% policy cap
  • centralize fee, royalty, and seller payout calculation with checked arithmetic and exact value conservation
  • apply the same accounting to primary sales, offers, and auction settlement, including cleanup and duplicate-settlement protection
  • add real Soroban token settlement tests for rounding, zero/max royalty, authorization, rollback, and cancellation cleanup
  • document the rounding and compatibility policy

Validation

  • rustfmt --edition 2021 --check contracts/commitment_marketplace/src/lib.rs contracts/commitment_marketplace/src/tests.rs ✅
  • git diff --check ✅
  • cargo test -p commitment-marketplace ⚠️ blocked before project compilation by the existing ethnum v1.5.2 compile error (cannot transmute between types of different sizes) in the dependency cache

Refs #555

@1nonlypiece
1nonlypiece merged commit 16d656c into Commitlabs-Org:master Aug 27, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants