Fix ColorPicker selection when IsColorSpectrumVisible is false#866
Open
lgztx96 wants to merge 1 commit into
Open
Fix ColorPicker selection when IsColorSpectrumVisible is false#866lgztx96 wants to merge 1 commit into
lgztx96 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
#701
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
When
ColorPicker.IsColorSpectrumVisibleis set toFalse, the color spectrum panel can still become selected even though it is collapsed.This happens because
ColorPicker.ValidateSelectedPanel()correctly selects the first visible panel, butSegmented.OnApplyTemplate()later restores a staleSelectedIndexvalue from_internalSelectedIndex, causing the hidden spectrum panel to be selected again.What is the new behavior?
ColorPickernow correctly respectsIsColorSpectrumVisible, and hidden panels are no longer reselected.The fix removes the default
SelectedIndex="0"from the XAML template, preventingSegmentedfrom caching an initial stale index in_internalSelectedIndex. This allowsValidateSelectedPanel()to preserve the correct visible selection.PR Checklist
Please check if your PR fulfills the following requirements:
(https://github.com/CommunityToolkit/WindowsCommunityToolkit-design-assets)
Other information