Skip to content

Align Renovate autodiscovery payload and GoShs docs example - #704

Merged
frjcomp merged 2 commits into
mainfrom
copilot/update-goshs-example
Sep 1, 2026
Merged

Align Renovate autodiscovery payload and GoShs docs example#704
frjcomp merged 2 commits into
mainfrom
copilot/update-goshs-example

Conversation

Copilot AI commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

This updates the documented Renovate exploitation flow to match the intended command/config defaults. It adds the missing manager constraint in generated renovate.json for autodiscovery and corrects the GoShs command shown in the guide.

  • Autodiscovery renovate.json generation

    • Added enabledManagers to the shared autodiscovery template used when creating renovate.json.
  • Template contract coverage

    • Extended autodiscovery template tests to assert the presence of the new enabledManagers setting.
  • Renovate guide command update

    • Replaced the GoShs example command with the requested flags/port.
{
  "enabledManagers": ["maven-wrapper"]
}
goshs --ssl --self-signed --upload-only --invisible --no-delete --port 8080

Copilot AI and others added 2 commits September 1, 2026 14:02
Co-authored-by: frjcomp <107982661+frjcomp@users.noreply.github.com>
Co-authored-by: frjcomp <107982661+frjcomp@users.noreply.github.com>
Copilot AI changed the title Update Renovate autodiscovery template for maven-wrapper manager Align Renovate autodiscovery payload and GoShs docs example Sep 1, 2026
Copilot AI requested a review from frjcomp September 1, 2026 15:09
@frjcomp
frjcomp marked this pull request as ready for review September 1, 2026 15:10
Copilot AI lite review requested due to automatic review settings September 1, 2026 15:10
@frjcomp
frjcomp enabled auto-merge (squash) September 1, 2026 15:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request aligns the Renovate autodiscovery exploit template and its documentation with the intended defaults by constraining Renovate to the maven-wrapper manager and updating the GoShs command shown in the Renovate guide.

Changes:

  • Add enabledManagers: ["maven-wrapper"] to the shared RenovateJSON template used for autodiscovery.
  • Extend the GitLab Renovate autodiscovery tests to assert the new enabledManagers setting is present.
  • Update the Renovate guide’s GoShs example command to the requested flags and port.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pkg/renovate/autodiscovery.go Updates the shared RenovateJSON template to include enabledManagers for maven-wrapper.
pkg/gitlab/renovate/autodiscovery/autodiscovery_test.go Adds a test assertion ensuring the template includes enabledManagers and maven-wrapper.
docs/guides/renovate.md Adjusts the GoShs server example command to match the documented exploitation flow (flags/port).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@frjcomp
frjcomp merged commit 4709765 into main Sep 1, 2026
14 checks passed
@frjcomp
frjcomp deleted the copilot/update-goshs-example branch September 1, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants