Repository navigation
feat: recognise DEFINE AGENT - #6
Open
vitorbabo-cf wants to merge 2 commits into
Open
vitorbabo-cf wants to merge 2 commits into
vitorbabo-cf wants to merge 2 commits into
Conversation
…rning lot_lint (Cursor plugin MCP) treated DEFINE AGENT as unknown. Mirror the broker parser: USES LLM ROUTE|CONNECTOR first, required DEFAULT_USER, ADD TOOL "name" with TOPICS|TARGET|LEVEL, deploy as -addAgent after routes. Also skip the missing-AS-TRIGGER warning when a model inherits via FROM.
github-actions
Bot
added
area: mcp-server
vitorbabo-cf
changed the title
2 of 3 tasks
vitorbabo-cf
changed the title
HugoAVaz
pushed a commit
that referenced
this pull request
Oct 20, 2026
## Summary The plugin stops carrying its own drifted copies of the LoT/broker skills. It now ships a pinned copy of [CorefluxCommunity/coreflux-skills](https://github.com/CorefluxCommunity/coreflux-skills), which is generated from the broker's skill sources and tagged per broker release. - **Synced skills** (tag `2.21.16-rc.186`): `broker-tools`, `lot-actions`, `lot-models`, `lot-routes`, `lot-rules`, `lot-agents`, `lot-things`, `lot-panels`, `lot-themes`, `python-scripts`. - **`scripts/sync-skills.mjs`**: `npm run skills:sync -- --ref <tag>` moves the pin, which is recorded as `brokerVersion` in `skills/skills.json`. `npm run skills:check` runs in CI and the release flow, and fails if the bundle differs from the pinned tag. Fixes go to the broker, not here. - **Removed:** the hand-written `lot-authoring`, `broker-commands`, `broker-observability`, `broker-security` and `lot-projects` skills. Several of their claims were wrong against the broker, including Python import blocklists, `USER HAS "AllowedSubscribe"`, user `SubscribeSys` rules, `METHOD`/`SWITCH` keywords and a number of route settings. - **New plugin-owned `coreflux-cursor-tools` skill:** the shared skills name the broker's own MCP tools (`deploy_lot`, `validate_lot`, `diagnose`, …), and this skill maps them to this plugin's tools. - **Updated to the new skill names:** rules, agents, commands and the session hook. `/coreflux-secure` no longer recommends user `SubscribeSys` rules, which are never consulted. - **`check-sources`:** the "only mention tools this server exposes" check skips the synced skills, which describe the broker's tool surfaces on purpose. - **`lot_deploy` / `lotnb_deploy`** now deploy `DEFINE THING`: every Thing block, templates included, goes as one `-addThing` after rules, matching the broker's deploy and folder loader. `lot_remove` takes `THING`. ## Stacked on #6 This branch merges `feat/ENG-426/lint-define-agent` (#6), which adds `DEFINE AGENT` deploy and lint. **Merge #6 first**; until then this PR's diff includes its changes. ## Content still missing from the broker skills The guidance the old skills had that the broker lacked (the raw MQTT command surface and reply format, the `$SYS` topic map, the troubleshooting checklist, users and secrets, projects and `.lotnb`, and LoT trigger and route examples) is being added to the broker as a new `broker-operations` skill plus edits to the LoT skills. It reaches this plugin with the next coreflux-skills tag, through `npm run skills:sync -- --ref <tag>`. ## Test plan - [x] `npm run ci`: validate, check-sources, skills:check, 74 unit tests - [x] `skills:check` fails on a hand-edited synced file - [ ] CI integration job against a real broker 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lot_lint/ entity splitting aboutDEFINE AGENT, matching the broker parser on main (USES LLM ROUTE|CONNECTOR, requiredWITH DEFAULT_USER,ADD TOOL "…" WITH TOPICS|TARGET|LEVEL, deploy via-addAgentafter routes).FROM Parent.Context
lot_lintlives in this plugin (plugins/coreflux/scripts/mcp/lib/lot.mjs), not the broker-validateLot. Other incomplete sites (left untouched):VSCodeLotNotebook/src/lot/lotAnalyzer.ts,coreflux-mcp/src/lot/parse.ts.Test plan
npm run ci(validate + check + 72 tests) green locallyFROMchild skips AS TRIGGER warning