Skip to content

JCF: supply reference rather than pointer to session in make_source_i…#437

Draft
jcfreeman2 wants to merge 1 commit into
developfrom
johnfreeman/file_formats_refactor
Draft

JCF: supply reference rather than pointer to session in make_source_i…#437
jcfreeman2 wants to merge 1 commit into
developfrom
johnfreeman/file_formats_refactor

Conversation

@jcfreeman2

Copy link
Copy Markdown
Contributor

…d_geo_id_map so the code compiles with changes I've performed on a branch of the same name in hdf5libs

Description

This draft PR is needed for the package to build against the primary draft PR, DUNE-DAQ/dfmodules#497 and the other packages with the same branch name available (hdf5libs, appmodel).

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

…d_geo_id_map so the code compiles with changes I've performed on a branch of the same name in hdf5libs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants