Skip to content

Leave navigation off a printed page - #370

Merged
tylercschneider merged 10 commits into
mainfrom
feature/print-navigation
Oct 15, 2026
Merged

tylercschneider merged 10 commits into
mainfrom
feature/print-navigation

Conversation

@tylercschneider

Copy link
Copy Markdown
Collaborator

One Sentence Summary

A person printing a page from an app built on keystone_ui, or saving it as a PDF, gets the page's content without the navigation around it.

ACs Covered

  • The navbar, the navigation component's top bar and sidebar, the bottom nav, the mobile header, the mobile actions menu, the breadcrumbs and the desktop back link are each left off a printed page.
  • On screen, each of them shows as it did.
  • The stylesheet test no longer fails, because it now expects the dark-mode selector in the form keystone_ui-styles 0.23.0 compiles.

Decision Log

Where is the keystone_ui stylesheet test fixed that keystone_ui-styles 0.23.0 broke?

In this navigation branch as its own commit, chosen over a separate pull request first or leaving it to whoever made the nested theme fix.

Code Example

Not relevant.

Out of Scope

Ticket Billed Against

Not specified.

Tokens Used

Not measured.

Effort

Not measured.


Generation Metadata

Scribe: pr-scribe adca11d
Rules: pr-body aec86e2, draft-reading 2e698a6, writing-style c3c2f61
Model: claude-sonnet-5-5, cc 2.1.299

🤖 Generated with Claude Code

tylercschneider and others added 10 commits October 15, 2026 16:42
keystone_ui-styles 0.23.0 wraps the dark selector in :is() so a light or custom wrapper inside a dark page stays light, and this test still expected the earlier selector.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tylercschneider
tylercschneider merged commit ce0cca6 into main Oct 15, 2026
6 checks passed
@tylercschneider
tylercschneider deleted the feature/print-navigation branch October 15, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant