Repository navigation
Leave navigation off a printed page - #370
Merged
Merged
Conversation
keystone_ui-styles 0.23.0 wraps the dark selector in :is() so a light or custom wrapper inside a dark page stays light, and this test still expected the earlier selector. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One Sentence Summary
A person printing a page from an app built on keystone_ui, or saving it as a PDF, gets the page's content without the navigation around it.
ACs Covered
Decision Log
Where is the keystone_ui stylesheet test fixed that keystone_ui-styles 0.23.0 broke?
Code Example
Not relevant.
Out of Scope
Ticket Billed Against
Not specified.
Tokens Used
Not measured.
Effort
Not measured.
Generation Metadata
Scribe: pr-scribe
adca11dRules: pr-body
aec86e2, draft-reading2e698a6, writing-stylec3c2f61Model:
claude-sonnet-5-5, cc2.1.299🤖 Generated with Claude Code