refactor(R1d): chart payload builders and map-layer conversion as tested modules

[himanshudube97]

Stacked on R1b. No behavior change — request bodies identical (E2E payload snapshots unchanged).

• logic/payload.ts: buildChartDataPayload(config, drill, builder), buildCreateChartPayload, buildEditChartPayload, resolveTableDimensions, TableDrillDownState — replacing the ~120-line memos and save literals in both builder pages.
• logic/map-layers.ts: toSimplifiedMapFields / toMapLayers.
• logic/builder-kind.ts: ChartBuilderKind.
• Create/edit differences are explicit, tested ("… differs between builders") and marked // BUILDER-DRIFT:; // PINNED-BUGS: only for rows in PINNED-BUGS.md.
• Accepted deviation: create's save no longer throws on a theoretical layers: [null] (never produced).
• FEATURES.md "Functions & logic" entries re-pointed to the new modules (Jest-covered).

Validation: full E2E suite on the R1 tip — 1237 passed, 3 flaky (passed on retry), 1 failure that passed 8/8 re-run alone (machine-load timeout). Payload snapshots unchanged. Jest + refactor gate green. Each task reviewed + whole-branch review.

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
webapp-v2	Ready	Preview	Oct 4, 2026 11:43am UTC

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 7295dc03-8c3a-45cf-b3db-e8f4c1515539

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[himanshudube97]

Closing: refactor stays local and will land as one combined branch.