This repository was archived by the owner on Oct 14, 2026. It is now read-only.
Repository navigation
refactor(R2a): chart-type switch as pure functions - #394
Closed
himanshudube97 wants to merge 1 commit into
Closed
himanshudube97 wants to merge 1 commit into
himanshudube97 wants to merge 1 commit into
Conversation
…84 cases applyChartTypeChange = ChartDataConfigurationV3's switch; legacyEditPageTypeSwitch = the edit page's second pass. Expected values generated from the pre-refactor code. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
Closing: refactor stays local and will land as one combined branch. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #391. No behavior change.
components/charts/logic/type-switch.ts:applyChartTypeChange(the data panel's rules) andlegacyEditPageTypeSwitch(the edit page's second pass). The edit page still runs both passes in today's order (incl. the pinned 422/legend/styling-reset bugs); create runs one; create-from-map path untouched.Validation: chart builder area E2E (26 chart spec files: builders, edit, detail, type-switch matrices (84 transitions), permutations, metrics matrices, save persistence, gaps) + cross-navigation — 899/899 passed, no flakes. Jest + refactor gate green. Every task reviewed (risky ones on the strongest model).
🤖 Generated with Claude Code