Skip to content

[DT-4263][7/7] Remove the email summary endpoint - #3151

Merged
kevinmarete merged 3 commits into
developfrom
km-dt-4263-remove-mail-summary
Oct 13, 2026
Merged

[DT-4263][7/7] Remove the email summary endpoint#3151
kevinmarete merged 3 commits into
developfrom
km-dt-4263-remove-mail-summary

Conversation

@kevinmarete

@kevinmarete kevinmarete commented Oct 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-4263

Security risk: no — removes an admin-only read endpoint.

Summary

#3150 and duos-ui #4011 are merged. Don't merge until duos-ui #4011 is deployed to every environment: it switches the Email Log from GET /api/mail/summary to GET /api/mail/sends, and the summary endpoint has no other caller.

Removes the endpoint, its DAO query, service method, MailMessageSummary model and mapper, OpenAPI path and schema, and their tests. The shared date and limit checks stay covered by the /sends tests.

Also clears the two Sonar issues #3150 left: \d in the DUOS-ID pattern, and one throwing call per assertThrows lambda in MailResourceTest. DAO tests now get unique DAR codes from DAOTestHelper.uniqueDarCode(), since random codes from narrow ranges occasionally collided on the unique dar_code and failed CI.

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

🤖 Generated with Claude Code

@kevinmarete kevinmarete changed the title [DT-4263] Remove the email summary endpoint [DT-4263][7/7] Remove the email summary endpoint Oct 10, 2026
@kevinmarete kevinmarete self-assigned this Oct 10, 2026
@kevinmarete
kevinmarete marked this pull request as ready for review October 10, 2026 05:25
@kevinmarete
kevinmarete requested a review from a team as a code owner October 10, 2026 05:25
@kevinmarete
kevinmarete requested review from fboulnois, otchet-broad and rushtong and removed request for a team October 10, 2026 05:25
otchet-broad
otchet-broad approved these changes Oct 12, 2026
View reviewed changes

@otchet-broad otchet-broad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rushtong
rushtong approved these changes Oct 13, 2026
View reviewed changes

@rushtong rushtong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

fboulnois
fboulnois approved these changes Oct 13, 2026
View reviewed changes

@fboulnois fboulnois left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice cleanup

@kevinmarete
kevinmarete force-pushed the km-dt-4263-email-search branch from 0e68115 to 387ea48 Compare October 13, 2026 16:45
@kevinmarete
kevinmarete force-pushed the km-dt-4263-remove-mail-summary branch 2 times, most recently from 2910dfc to ddd8e26 Compare October 13, 2026 18:05
@kevinmarete
kevinmarete force-pushed the km-dt-4263-email-search branch from 387ea48 to dec1ded Compare October 13, 2026 18:05
@kevinmarete
kevinmarete force-pushed the km-dt-4263-remove-mail-summary branch from ddd8e26 to 02682e1 Compare October 13, 2026 18:27
@kevinmarete
kevinmarete force-pushed the km-dt-4263-email-search branch 2 times, most recently from 6ef7cf3 to 81e4983 Compare October 13, 2026 18:56
@kevinmarete
kevinmarete force-pushed the km-dt-4263-remove-mail-summary branch from 02682e1 to 79e27e4 Compare October 13, 2026 18:56
@kevinmarete
kevinmarete force-pushed the km-dt-4263-email-search branch from 81e4983 to 48c2135 Compare October 13, 2026 19:15
@kevinmarete
kevinmarete force-pushed the km-dt-4263-remove-mail-summary branch 2 times, most recently from 00e3aa2 to e914895 Compare October 13, 2026 19:56
@kevinmarete
kevinmarete force-pushed the km-dt-4263-email-search branch from 48c2135 to 123ee8d Compare October 13, 2026 19:56
@kevinmarete
kevinmarete force-pushed the km-dt-4263-remove-mail-summary branch from e914895 to e77e10d Compare October 13, 2026 22:14
@kevinmarete
kevinmarete force-pushed the km-dt-4263-email-search branch from 123ee8d to 76724d0 Compare October 13, 2026 22:14
Base automatically changed from km-dt-4263-email-search to develop October 13, 2026 22:31
kevinmarete and others added 2 commits October 13, 2026 18:36
@kevinmarete @claude
[DT-4263] Remove the email summary endpoint
9ef9f22 
The Email Log reads /api/mail/sends now, so nothing calls /api/mail/summary.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kevinmarete @claude
Clear two Sonar issues from the sends search
3aba88d 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 13, 2026 22:38
@kevinmarete
kevinmarete force-pushed the km-dt-4263-remove-mail-summary branch from e77e10d to 3aba88d Compare October 13, 2026 22:38
Copilot AI reviewed Oct 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kevinmarete @claude
Give each test DAR collection a unique code
0441cc2 
Codes drawn from narrow random ranges collided on the unique dar_code
column now and then, failing CI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Oct 13, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kevinmarete
kevinmarete merged commit 499563d into develop Oct 13, 2026
11 checks passed
@kevinmarete
kevinmarete deleted the km-dt-4263-remove-mail-summary branch October 13, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rushtong rushtong rushtong approved these changes
@fboulnois fboulnois fboulnois approved these changes
@otchet-broad otchet-broad otchet-broad approved these changes

Assignees

@kevinmarete kevinmarete

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kevinmarete @rushtong @fboulnois @otchet-broad