ci(integration): stabilize Lambda log snapshots - #824
Merged
joeyzhao2018 merged 5 commits intoSep 2, 2026
Conversation
This comment has been minimized.
This comment has been minimized.
BridgeAR
force-pushed
the
BridgeAR/2026-09-01-integration-log-resilience
branch
2 times, most recently
from
September 1, 2026 23:51
7152e60 to
3d71476
Compare
A successful log fetch could still contain fewer completions than were invoked, and AWS proactive initialization changes cold-start fields without a library behavior change. Both cases made the snapshots depend on platform timing. The AWS snapshots now wait for every completion and ignore only scheduler-owned fields. RIE and focused telemetry tests retain cold-start and proactive-initialization coverage.
1. A relative runner invocation leaves its helper directory relative, so later directory changes make every log normalization call miss the executable. 2. Successful Serverless diagnostics entered the log payload and could produce false snapshot mismatches.
The former `INIT_START` substitution left an empty line in stored zip snapshots, so current output that deletes the whole line failed every zip-handler comparison.
BridgeAR
force-pushed
the
BridgeAR/2026-09-01-integration-log-resilience
branch
from
September 2, 2026 16:12
3d71476 to
b5045c6
Compare
BridgeAR
marked this pull request as ready for review
September 2, 2026 17:02
joeyzhao2018
approved these changes
Sep 2, 2026
joeyzhao2018
left a comment
Contributor
There was a problem hiding this comment.
LGTM. good catch. btw, we are also migrating these real aws-lambda based tests to serverless-e2e-tests
joeyzhao2018
deleted the
BridgeAR/2026-09-01-integration-log-resilience
branch
September 2, 2026 19:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CloudWatch returned successful responses before every invocation log was visible. The runner accepted those partial results as snapshot input.
AWS can initialize a sandbox more than ten seconds before its first invocation. This adds proactive-initialization telemetry and changes
cold_start, but the broad snapshots treated both scheduler-owned fields as library regressions. Stored zip snapshots also kept a blank line from the formerINIT_STARTsubstitution.The runner now polls until every expected completion record is present and uses one AWS/RIE-aware normalizer for current output and snapshots. AWS removes scheduler-owned fields and historical padding. RIE retains
cold_start, and focused trace and metric tests pin proactive-initialization behavior.The runner also resolves its helper directory before changing directories and keeps successful Serverless diagnostics on stderr. Polling starts immediately instead of waiting for the former fixed 20-second delay.