Use agent OTel metrics for OpenFeature evaluations#11745
Draft
sameerank wants to merge 1 commit into
Draft
Conversation
Contributor
🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This updates the OpenFeature feature flag evaluation metrics implementation to record through
GlobalOpenTelemetryinstead of constructing its own OpenTelemetry SDK meter provider and OTLP HTTP exporter.It also removes the OpenTelemetry SDK/exporter dependencies from
feature-flagging-api, refreshes the lockfile, and updates the README to document that evaluation metrics use the Datadog Java agent OpenTelemetry metrics pipeline withDD_METRICS_OTEL_ENABLED=true.Why
The previous implementation required
opentelemetry-sdk-metricsandopentelemetry-exporter-otlpon the application classpath and always created an OTLP HTTP exporter. That did not line up with customers already using the Datadog Java agent OTel metrics pipeline for custom metrics, especially when their Agent OTLP receiver is configured for gRPC only.With this change,
feature_flag.evaluationsuses the same configured Java agent OTel metrics pipeline as other custom OTel metrics.Validation
./gradlew :products:feature-flagging:feature-flagging-api:dependencies --write-locks./gradlew :products:feature-flagging:feature-flagging-api:testgit diff --checkgit diff --cached --checkNoted local blockers/noisy checks:
./gradlew :products:feature-flagging:feature-flagging-api:spotlessCheckis currently blocked by:spotlessInternalRegisterDependenciesfailing to provision P2 dependencies../gradlew :dd-java-agent:instrumentation:opentelemetry:opentelemetry-1.47:testfails before tests in unrelated:dd-java-agent:agent-jmxfetch:compileJava; the localotel-bootstrapshadow artifact is missingdatadog.trace.bootstrap.otel.api.common.AttributeKeyandAttributes.