test(appsec): replace axios with fetch - #10076
Conversation
Overall package sizeSelf size: 8.85 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.4.0 | 127.33 kB | 447.04 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
BenchmarksBenchmark execution time: 2026-09-08 16:02:17 Comparing candidate commit 43bba41 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2304 metrics, 9 unstable metrics.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10076 +/- ##
==========================================
- Coverage 98.68% 98.67% -0.01%
==========================================
Files 1006 1006
Lines 158039 158039
Branches 74 74
==========================================
- Hits 155957 155952 -5
- Misses 2082 2087 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97bc30d9c4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
97bc30d to
fa67ca5
Compare
Fetch resolves when response headers arrive. The test helpers consume each response body before reporting completion, which preserves the existing request timing.
Fetch resolves when response headers arrive. Each helper consumes the response body before assertions run, which preserves the existing request timing.
Fetch resolves when response headers arrive. Each helper consumes the response body before the test proceeds, preserving the prior request completion timing.
Fetch resolves when response headers arrive. The helper consumes the response body before the test completes, preserving the prior request timing.
Fetch resolves when response headers arrive. The helper consumes the response body before the test completes, preserving the prior request timing.
Fetch resolves 4xx and 5xx responses, unlike the Axios calls these helpers replaced. Without an explicit success check, the tests can pass after a broken request.
fa67ca5 to
43bba41
Compare
Fetch resolves when response headers arrive. The test helpers consume each response body before reporting completion, which preserves the existing request timing.
Fetch resolves when response headers arrive. The test helpers consume each response body before reporting completion, which preserves the existing request timing.
Fetch resolves when response headers arrive. The test helpers consume each response body before reporting completion, which preserves the existing request timing.