fix(graphql): record reused non-JIT resolver errors - #10082
Merged
BridgeAR merged 2 commits intoSep 2, 2026
Merged
Conversation
Contributor
Overall package sizeSelf size: 8.64 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.4.0 | 127.33 kB | 447.04 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
✅ All CI checks and tests passed. Datadog automation helped this PR pass. 🎉 All green!🧪 All tests passed 🔄 Datadog retried 1 test - 1 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: 754c778 | Docs | View more details | Give us feedback! |
BenchmarksBenchmark execution time: 2026-09-01 09:19:13 Comparing candidate commit 754c778 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2300 metrics, 10 unstable metrics.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10082 +/- ##
========================================
Coverage 98.62% 98.62%
========================================
Files 996 997 +1
Lines 152043 152260 +217
Branches 13193 12671 -522
========================================
+ Hits 149956 150174 +218
+ Misses 2087 2086 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collapsed non-JIT fields reused the first span without observing later resolver completion, so a sibling rejection left the shared span and resolve hook successful.
Reused collapsed resolver calls share one span, but the prior error tracking entered a new async context and observed every call. GraphQL already normalizes resolver failures, so record errors at that boundary and leave successful reused calls unchanged. Only delayed non-JIT resolve hooks release their field before the execute hook. JIT and execute-only paths retain their existing hook order.
BridgeAR
force-pushed
the
BridgeAR/2026-08-31-graphql-non-jit-resolver-errors
branch
from
September 1, 2026 09:09
de27cf9 to
754c778
Compare
BridgeAR
marked this pull request as ready for review
September 1, 2026 12:13
bengl
approved these changes
Sep 2, 2026
BridgeAR
deleted the
BridgeAR/2026-08-31-graphql-non-jit-resolver-errors
branch
September 2, 2026 17:56
Merged
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Sep 3, 2026
* fix(graphql): record reused resolver errors Collapsed non-JIT fields reused the first span without observing later resolver completion, so a sibling rejection left the shared span and resolve hook successful. * perf(graphql): move collapsed resolver error tracking off hot path Reused collapsed resolver calls share one span, but the prior error tracking entered a new async context and observed every call. GraphQL already normalizes resolver failures, so record errors at that boundary and leave successful reused calls unchanged. Only delayed non-JIT resolve hooks release their field before the execute hook. JIT and execute-only paths retain their existing hook order.
Merged
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Sep 3, 2026
* fix(graphql): record reused resolver errors Collapsed non-JIT fields reused the first span without observing later resolver completion, so a sibling rejection left the shared span and resolve hook successful. * perf(graphql): move collapsed resolver error tracking off hot path Reused collapsed resolver calls share one span, but the prior error tracking entered a new async context and observed every call. GraphQL already normalizes resolver failures, so record errors at that boundary and leave successful reused calls unchanged. Only delayed non-JIT resolve hooks release their field before the execute hook. JIT and execute-only paths retain their existing hook order.
BridgeAR
added a commit
that referenced
this pull request
Sep 4, 2026
* fix(graphql): record reused resolver errors Collapsed non-JIT fields reused the first span without observing later resolver completion, so a sibling rejection left the shared span and resolve hook successful. * perf(graphql): move collapsed resolver error tracking off hot path Reused collapsed resolver calls share one span, but the prior error tracking entered a new async context and observed every call. GraphQL already normalizes resolver failures, so record errors at that boundary and leave successful reused calls unchanged. Only delayed non-JIT resolve hooks release their field before the execute hook. JIT and execute-only paths retain their existing hook order.
BridgeAR
added a commit
that referenced
this pull request
Sep 4, 2026
* fix(graphql): record reused resolver errors Collapsed non-JIT fields reused the first span without observing later resolver completion, so a sibling rejection left the shared span and resolve hook successful. * perf(graphql): move collapsed resolver error tracking off hot path Reused collapsed resolver calls share one span, but the prior error tracking entered a new async context and observed every call. GraphQL already normalizes resolver failures, so record errors at that boundary and leave successful reused calls unchanged. Only delayed non-JIT resolve hooks release their field before the execute hook. JIT and execute-only paths retain their existing hook order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapsed non-JIT fields reuse one span, but a sibling rejection could leave that span and its resolve hook successful.
GraphQL normalizes resolver failures before execution completes. Recording the error at that boundary keeps successful reused calls on the existing collapsed fast path. The first error wins, and a falsy rejection receives a real Error. The resolve hook still runs once before the execute hook.