Conversation
🔒 Cargo Deny Results📦 Root workspace - 5 error(s), 19 warning(s)Show output |
This was referenced Aug 28, 2026
bm1549
force-pushed
the
brian.marks/otel-deployment-environment-name
branch
from
August 28, 2026 17:01
a3b3672 to
f8c9679
Compare
zacharycmontoya
added a commit
to DataDog/dd-trace-dotnet
that referenced
this pull request
Sep 18, 2026
## Summary of changes Map `deployment.environment.name` to the Datadog environment. Keep `deployment.environment` as a fallback, and keep `DD_ENV` as the highest-precedence source. ## Reason for change OpenTelemetry stabilized the deployment environment semantic convention under `deployment.environment.name`. Related PRs: - DataDog/system-tests#7613 - DataDog/dd-trace-go#5285 - #9150 - DataDog/dd-trace-rb#6261 - DataDog/dd-trace-php#4148 - DataDog/dd-trace-js#10050 - DataDog/dd-trace-rs#300 - DataDog/dd-trace-java#12324 - DataDog/dd-trace-py#19901 ## Implementation details The resource attribute mapper tracks the stable and legacy values separately, then chooses the stable value regardless of input order. It removes both source aliases after promotion and leaves unrelated attributes alone. ## Test coverage Five focused mapping cases and 182 adjacent configuration tests passed locally. Formatting checks also passed. ## Other details None. --------- Co-authored-by: Zach Montoya <zach.montoya@datadoghq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Maps
deployment.environment.nameto the Datadog environment, withdeployment.environmentas a fallback and an explicitDD_ENVoverride. The mapping applies to tracer configuration, emitted spans, and OpenTelemetry metrics and logs resources.Motivation
OpenTelemetry stabilized the deployment environment semantic convention under
deployment.environment.name.Related PRs:
Additional Notes
The OTel value remains a fallback instead of being promoted to explicit Datadog configuration, so caller-provided resources and
DD_TAGSkeep their existing priority. Both aliases are consumed after mapping, while unrelated attributes remain. The full non-integration suite, doc tests, formatting, and all feature combinations in Clippy pass. The system-test config assertion remains excluded because the Rust test app does not implement/trace/config; the emitted-span assertion runs normally.