feat: replace v04 usage by v1 in sidecar - #2156
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 13 commits intoAug 25, 2026
Merged
feat: replace v04 usage by v1 in sidecar#2156gh-worker-dd-mergequeue-cf854d[bot] merged 13 commits into
gh-worker-dd-mergequeue-cf854d[bot] merged 13 commits into
Conversation
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 4dca4dc | Docs | View more details | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
bwoebi
reviewed
Jul 16, 2026
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
that referenced
this pull request
Jul 28, 2026
# What does this PR do? Splits `TracerHeaderTags` into two parts: the tracer-identity strings (`lang`, `lang_version`, `tracer_version`, etc.) stay as-is, and the generic bool/int flags (`client_computed_stats`, `client_computed_top_level`, `dropped_p0_traces`, `dropped_p0_spans`) are pulled into a new standalone `TracerGenericTags` struct, embedded as `TracerHeaderTags::generic`. # Motivation `TracerHeaderTags` mixed tracer-identity strings with generic bool/int flags. The latter are meaningful independently of the string metadata, so pulling them into their own struct lets them be carried on their own in contexts where the string fields would be redundant (e.g. payload formats that already embed the tracer identity), without forcing a full split of the type. # Additional Notes Raised during review of #2156. Prepared as a separate PR to keep #2156 scoped to the sidecar-specific V04→V1 changes. This PR alone is a no-op refactor — `TracerGenericTags` is still only used embedded in `TracerHeaderTags`. The actual payoff comes in #2156: the V1 trace-sending path already carries the tracer identity in the V1 payload itself, so `send_trace_v1` will be able to pass just `TracerGenericTags` (a small `Copy` struct, no serialization needed) across the sidecar's IPC boundary instead of the full `TracerHeaderTags`/`SerializedTracerHeaderTags`, which currently re-transmits redundant string data. Co-authored-by: anais.raison <anais.raison@datadoghq.com>
…4-to-v1-span # Conflicts: # libdd-data-pipeline/src/trace_exporter/trace_serializer.rs # libdd-trace-utils/src/msgpack_decoder/v1/mod.rs # libdd-trace-utils/src/msgpack_decoder/v1/span.rs # libdd-trace-utils/src/send_data/mod.rs # libdd-trace-utils/src/tracer_payload.rs # libdd-trace-utils/tests/test_send_data.rs
…andlers Merging main's SidecarInterface trait update (which dropped the peer-credentials parameter from send_trace handlers) into this branch left the v1 trace handlers with a param the trait no longer declares, breaking the build after the merge. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
BenchmarksComparisonCandidateCandidate benchmark detailsBaselineBaseline benchmark details |
anais-raison
marked this pull request as ready for review
July 31, 2026 12:26
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 938c110d26
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Leiyks
reviewed
Aug 5, 2026
Leiyks
left a comment
Leiyks
left a comment
Contributor
There was a problem hiding this comment.
Except the V1 payloads being posted on the V04 endpoint and few nits, the rest looks good 👌
gh-worker-ownership-write-b05516
Bot
removed the request for review
from a team
August 10, 2026 09:35
yannham
approved these changes
Aug 10, 2026
bwoebi
reviewed
Aug 10, 2026
bwoebi
reviewed
Aug 18, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
anais/sidecar-from-v04-to-v1-span
branch
August 25, 2026 14:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Wires the sidecar so SDKs (PHP first) can send V1 msgpack payloads. Adds the FFI entry points, tarpc methods, blocking/sender wrappers, and server handlers — symmetric to the existing
send_trace_v04_*chain.When the sidecar receives V1 bytes, it decodes them through
msgpack_decoder::v1(added in #2174), can inspect the payload, and re-encodes as V1 on the way to the agent's/v1.0/tracesendpoint.Motivation
APMSP-2813 : enable the sidecar V1-native path. PHP keeps computing its stats SDK-side via the SHM concentrator, so this PR only touches the trace transport pipeline.