You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Test binaries inherit [profile.dev] debug = 2 (full debug info) from root Cargo.toml.
Motivation
This dominated Windows link/PDB time and cached target size
Additional Notes
line-tables-only keeps file/line info for backtraces and llvm-cov.
How to test the change?
On the first commit of this PR, it took 38min, which is pretty much in line with before the change, but cache needed rebuilding, I pushed an empty commit and it took less than 20 minutes, it might be a fluke, I'll do another empty commit, but it might be really big improvement for not much.
Apparently though, having a warm cache is pretty hard, and the 10gb repo limit is exceeded and cache evicted extremely quickly. Once caching is done by sccache, we would have the full upside of this, and it could have a real impact
Comparing candidate commit 051e9c4 in PR branch jwiriath/APMSP-3942-line-table-only with baseline commit 24022a9 in branch main.
Found 7 performance improvements and 0 performance regressions! Performance is the same for 161 metrics, 10 unstable metrics.
Explanation
This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:
🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline
We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.
If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.
Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.
More details about the CI and significant changes
You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.
CIs of the difference of means are often centered around 0%, because often changes are not that big:
---------------------------------(------|---^--------)-------------------------------->
-0.6% 0% 0.3% +1.2%
| | |
lower bound of the CI --' | |
sample mean (center of the CI) -------------' |
upper bound of the CI ----------------------'
As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).
For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:
----------------------------------------|---------|---(---------^---------)---------->
0% 1% 1.3% 2.2% 3.1%
| | | |
significant impact threshold --------------' | | |
lower bound of CI --------------' | |
sample mean (center of the CI) --------------------------' |
upper bound of CI ----------------------------------'
scenario:alloc_free/system/4096
🟩 execution_time [-12.839ns; -12.665ns] or [-12.098%; -11.934%]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test binaries inherit [profile.dev] debug = 2 (full debug info) from root Cargo.toml.
Motivation
This dominated Windows link/PDB time and cached target size
Additional Notes
line-tables-onlykeeps file/line info for backtraces and llvm-cov.How to test the change?
On the first commit of this PR, it took 38min, which is pretty much in line with before the change, but cache needed rebuilding, I pushed an empty commit and it took less than 20 minutes, it might be a fluke, I'll do another empty commit, but it might be really big improvement for not much.
Apparently though, having a warm cache is pretty hard, and the 10gb repo limit is exceeded and cache evicted extremely quickly. Once caching is done by sccache, we would have the full upside of this, and it could have a real impact