feat(feature-flags): support extended SemVer fixtures - #2401
Closed
greghuels wants to merge 1 commit into
Closed
Conversation
Contributor
📚 Documentation Check Results📦
|
Contributor
🔒 Cargo Deny Results📦
|
BenchmarksComparisonCandidateCandidate benchmark detailsBaselineBaseline benchmark details |
Contributor
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 4b4c517 | Docs | View more details | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
greghuels
marked this pull request as ready for review
August 24, 2026 18:32
greghuels
requested review from
typotter and
vjfridge
and removed request for
a team
August 24, 2026 18:32
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b4c5178fa
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } => { | ||
| let attr_str = attribute?.as_str()?; | ||
| let attr_version = semver::Version::parse(attr_str.as_ref()).ok()?; | ||
| let attr_version = ExtendedVersion::parse(attr_str.as_ref())?; |
There was a problem hiding this comment.
For every SEMVER_* condition evaluation, parsing the subject attribute now allocates an owned Box<str>, a boxed component vector, and a normalized String, although the temporary attribute version is discarded immediately afterward. This turns a previously allocation-free common x.y.z parse into repeated heap churn on the request-time flag-evaluation path; use borrowed suffixes and a fixed-size component array, retaining the original owned string only for configuration comparands that must round-trip.
AGENTS.md reference: AGENTS.md:L70-L76
Useful? React with 👍 / 👎.
Contributor
Author
|
Closing in favor of a PR that doesn't include regex changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ffe-system-test-datato d9b05ae23d861228e210b9f4b7b1e5a926f88878.Validation
cargo nextest run -p libdd-ffe(32 passed)cargo nextest run -p libdd-ffe-test-suitecargo check -p libdd-ffe, format check, clippy, andgit diff --check.