Auto-activate ruby easy wins for apm-sdk-capabilities - #7546
Auto-activate ruby easy wins for apm-sdk-capabilities#7546dd-octo-sts[bot] wants to merge 1 commit into
Conversation
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: approved - manual merge required (this rule does not auto-merge) |
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cbe89c0f40
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| : "irrelevant (\"Ruby tracer decided to always set _dd1.sr.eausr: 1 for truthy analytics.event inputs, else 0\")" | ||
| tests/parametric/test_otel_span_with_baggage.py::Test_Otel_Span_With_Baggage: missing_feature | ||
| tests/parametric/test_otel_tracestate_sampling.py::Test_OtelTracestateSampling: v2.42.0-dev | ||
| tests/parametric/test_otel_tracestate_sampling.py::Test_OtelTracestateSampling: v2.42.0-dev # Easy win for all weblogs and version 2.41.0 |
There was a problem hiding this comment.
Lower the gate to the passing Ruby version
For the PARAMETRIC run at Ruby 2.41.0 recorded by this easy-win update, the manifest still requires v2.42.0-dev; because a v entry enables the test only at that version and above, Ruby 2.41.0 continues to skip this entire class. Update the version value rather than only appending the comment, otherwise this auto-activation provides no additional test coverage.
Useful? React with 👍 / 👎.
cbe89c0 to
db69c56
Compare
new commit added, dismiss all previous approvals
db69c56 to
503d68a
Compare
new commit added, dismiss all previous approvals
503d68a to
3a3fc0b
Compare
new commit added, dismiss all previous approvals
3a3fc0b to
6cf51af
Compare
new commit added, dismiss all previous approvals
6cf51af to
eca8a20
Compare
new commit added, dismiss all previous approvals
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eca8a20 to
bd8be8a
Compare
new commit added, dismiss all previous approvals
Automated activation of easy-win tests for
rubyowned byapm-sdk-capabilitiesView nightly workflow run