fix(golang): trace non-standard HTTP methods in Chi weblog - #7583
Merged
Conversation
Contributor
|
|
marcotc
force-pushed
the
apmapi-2127-chi-otel-wiring
branch
from
August 25, 2026 21:05
f74b623 to
982554e
Compare
marcotc
marked this pull request as ready for review
August 25, 2026 21:11
marcotc
force-pushed
the
apmapi-2127-chi-otel-wiring
branch
from
August 25, 2026 21:12
982554e to
e0412d1
Compare
🎉 All green!🧪 All tests passed 🔗 Commit SHA: e0412d1 | Docs | View more details | Give us feedback! |
zacharycmontoya
approved these changes
Aug 25, 2026
zacharycmontoya
left a comment
Contributor
There was a problem hiding this comment.
I don't see risk in merging this as-is, but it would be better if we merged this with an additional change to unskip a Chi weblog test case
link04
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Chi rejects non-standard HTTP methods before the route middleware runs.
As a result, test that exercise non-standard HTTP methods don't execute correctly.
This supports APMAPI-2127 and the server semantic-convention behavior in DataDog/dd-trace-go#5242.
Changes
Allow the non-standard HTTP method used by semantic-convention coverage to reach route tracing middleware.
We can't simply restore a global middleware, since that breaks AppSec.
We use
PROPFINDbecause that's the "non-standard HTTP method" we use today.Validation:
./format.shgit diff --checkLocal image build and focused scenario validation were blocked because the sandbox denied Docker Hub access while fetching
golang:1.26-alpine.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present