Skip to content

fix(golang): trace non-standard HTTP methods in Chi weblog - #7583

Merged
marcotc merged 1 commit into
mainfrom
apmapi-2127-chi-otel-wiring
Aug 25, 2026
Merged

fix(golang): trace non-standard HTTP methods in Chi weblog#7583
marcotc merged 1 commit into
mainfrom
apmapi-2127-chi-otel-wiring

Conversation

@marcotc

@marcotc marcotc commented Aug 25, 2026

Copy link
Copy Markdown
Member

Motivation

Chi rejects non-standard HTTP methods before the route middleware runs.
As a result, test that exercise non-standard HTTP methods don't execute correctly.

This supports APMAPI-2127 and the server semantic-convention behavior in DataDog/dd-trace-go#5242.

Changes

Allow the non-standard HTTP method used by semantic-convention coverage to reach route tracing middleware.
We can't simply restore a global middleware, since that breaks AppSec.

We use PROPFIND because that's the "non-standard HTTP method" we use today.

Validation:

  • ./format.sh
  • git diff --check

Local image build and focused scenario validation were blocked because the sandbox denied Docker Hub access while fetching golang:1.26-alpine.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/build/docker/golang/app/chi/main.go                               @DataDog/system-tests-reviewers

@marcotc
marcotc force-pushed the apmapi-2127-chi-otel-wiring branch from f74b623 to 982554e Compare August 25, 2026 21:05
@marcotc marcotc changed the title fix(golang): register PROPFIND in Chi weblog fix(golang): trace non-standard HTTP methods in Chi weblog Aug 25, 2026
@marcotc
marcotc marked this pull request as ready for review August 25, 2026 21:11
@marcotc
marcotc requested a review from a team as a code owner August 25, 2026 21:11
@marcotc
marcotc requested review from lloeki and removed request for a team August 25, 2026 21:11
@marcotc
marcotc force-pushed the apmapi-2127-chi-otel-wiring branch from 982554e to e0412d1 Compare August 25, 2026 21:12
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Aug 25, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e0412d1 | Docs | View more details | Give us feedback!

@zacharycmontoya zacharycmontoya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see risk in merging this as-is, but it would be better if we merged this with an additional change to unskip a Chi weblog test case

@marcotc
marcotc merged commit 21b3357 into main Aug 25, 2026
668 of 669 checks passed
@marcotc
marcotc deleted the apmapi-2127-chi-otel-wiring branch August 25, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants