Skip to content

test(golang): add go-restful OTel semantics weblog - #7585

Open
marcotc wants to merge 1 commit into
maximo/otel-semantics-system-tests-v3from
marcotc/apmapi-2047-go-restful-v3
Open

test(golang): add go-restful OTel semantics weblog#7585
marcotc wants to merge 1 commit into
maximo/otel-semantics-system-tests-v3from
marcotc/apmapi-2047-go-restful-v3

Conversation

@marcotc

@marcotc marcotc commented Aug 25, 2026

Copy link
Copy Markdown
Member

Motivation

APMAPI-2047 extends the OpenTelemetry HTTP semantics RFC system-test coverage to a real go-restful v3 server integration.

This PR builds on #7573, which owns the shared OpenTelemetry HTTP test expectation changes.

Changes

  • Add a minimal go-restful-v3 Go weblog with framework-native route matching and traced net/http downstream calls.
  • Add shared router-neutral endpoint behavior for OpenTelemetry HTTP semantics weblogs.
  • Schedule the weblog only for the four existing OpenTelemetry HTTP semantics scenarios.
  • Keep the legacy scenario-matrix parity check aligned with the restricted weblog variant.

Validation

The weblog builds and passes all forced semantic test classes against dd-trace-go commit 3f75582cb90f232ddcace4ebd2fc7a2296320851. ./format.sh, scenario-selection validation, and relevant TEST_THE_TEST checks also pass.

Stack

Gotchas

The Go manifest remains unchanged because the eventual dd-trace-go release version is not known. The semantic classes therefore remain marked missing_feature until that release version can be recorded; this PR stays draft meanwhile.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/build/docker/golang/app/_shared/otel_semantics/handlers.go        @DataDog/system-tests-reviewers
utils/build/docker/golang/app/go-restful-v3/main.go                     @DataDog/system-tests-reviewers
utils/build/docker/golang/go-restful-v3.Dockerfile                      @DataDog/system-tests-reviewers
docs/execute/build.md                                                   @DataDog/system-tests-core
manifests/dotnet.yml                                                    @DataDog/system-tests-reviewers
manifests/golang.yml                                                    @DataDog/system-tests-reviewers
manifests/java.yml                                                      @DataDog/system-tests-reviewers
manifests/nodejs.yml                                                    @DataDog/system-tests-reviewers
manifests/php.yml                                                       @DataDog/system-tests-reviewers
manifests/python.yml                                                    @DataDog/system-tests-reviewers
manifests/ruby.yml                                                      @DataDog/system-tests-reviewers
manifests/rust.yml                                                      @DataDog/system-tests-reviewers
tests/test_otel_http_semantics.py                                       @DataDog/system-tests-core
tests/test_the_test/test_ci_orchestrator.py                             @DataDog/system-tests-core
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core
utils/build/docker/golang/app/go.mod                                    @DataDog/system-tests-reviewers
utils/build/docker/golang/app/go.sum                                    @DataDog/system-tests-reviewers
utils/build/docker/golang/weblog_metadata.yml                           @DataDog/system-tests-reviewers

@marcotc
marcotc force-pushed the marcotc/apmapi-2047-go-restful-v3 branch from 1a9fb8f to 5aef48d Compare August 25, 2026 23:36
@marcotc
marcotc changed the base branch from main to maximo/otel-semantics-system-tests-v3 August 25, 2026 23:37
@marcotc
marcotc marked this pull request as ready for review August 25, 2026 23:43
@marcotc
marcotc requested review from a team as code owners August 25, 2026 23:43
@marcotc
marcotc requested review from OmerRaviv and removed request for a team August 25, 2026 23:43

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5aef48d268

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +32 to +35
- OTEL_SEMANTICS_OTLP
- OTEL_SEMANTICS_OTLP_CUSTOM_ERROR_STATUSES
- OTEL_SEMANTICS_OTLP_TRACE_METRICS
- OTEL_SEMANTICS_OTLP_SAMPLING_RULES

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Activate the OTel semantics tests for the new weblog

When CI schedules these scenarios for go-restful-v3, all corresponding test classes remain unconditionally disabled as missing_feature in manifests/golang.yml:1817-1821. Scenario metadata does not override manifest restrictions, so these jobs launch the new weblog but execute none of the OTel semantics validations. Replace the broad declarations with appropriate version- or weblog-specific activation for go-restful-v3, while retaining skips where the feature remains unsupported. .cursor/rules/test-activation.mdcL22-L31

Useful? React with 👍 / 👎.

@datadog-official

datadog-official Bot commented Aug 26, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5aef48d | Docs | View more details | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant