test(golang): add go-restful OTel semantics weblog - #7585
Conversation
|
|
1a9fb8f to
5aef48d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5aef48d268
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - OTEL_SEMANTICS_OTLP | ||
| - OTEL_SEMANTICS_OTLP_CUSTOM_ERROR_STATUSES | ||
| - OTEL_SEMANTICS_OTLP_TRACE_METRICS | ||
| - OTEL_SEMANTICS_OTLP_SAMPLING_RULES |
There was a problem hiding this comment.
Activate the OTel semantics tests for the new weblog
When CI schedules these scenarios for go-restful-v3, all corresponding test classes remain unconditionally disabled as missing_feature in manifests/golang.yml:1817-1821. Scenario metadata does not override manifest restrictions, so these jobs launch the new weblog but execute none of the OTel semantics validations. Replace the broad declarations with appropriate version- or weblog-specific activation for go-restful-v3, while retaining skips where the feature remains unsupported. .cursor/rules/test-activation.mdcL22-L31
Useful? React with 👍 / 👎.
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 5aef48d | Docs | View more details | Give us feedback! |
Motivation
APMAPI-2047 extends the OpenTelemetry HTTP semantics RFC system-test coverage to a real go-restful v3 server integration.
This PR builds on #7573, which owns the shared OpenTelemetry HTTP test expectation changes.
Changes
go-restful-v3Go weblog with framework-native route matching and tracednet/httpdownstream calls.Validation
The weblog builds and passes all forced semantic test classes against dd-trace-go commit
3f75582cb90f232ddcace4ebd2fc7a2296320851../format.sh, scenario-selection validation, and relevantTEST_THE_TESTchecks also pass.Stack
Gotchas
The Go manifest remains unchanged because the eventual dd-trace-go release version is not known. The semantic classes therefore remain marked
missing_featureuntil that release version can be recorded; this PR stays draft meanwhile.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present