Refactor auth_* methods to use TLS 1.2 on Windows. - #310
Merged
Conversation
Includes general refactor to move most HTTP logic to `auth_request.R` and some cleanup of tests so they are skipped when offline. Pertains to issue #308
2 tasks
Member
Author
|
Completed testing in this PR to fall-back to TLS 1.2 on Windows clients. This allows the tests to pass on win-builder, even though they are still failing here in GHA builders under Windows. I am going ahead with this merge and release as it seems to solve most of the problems on Windows. Others also seem to have trouble with the Windows GHA runners for R packages, so I will need to look into this for the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes general refactor to move most HTTP logic to
auth_request.Rand some cleanup of tests so they are skipped when offline.Pertains to issue #308