Skip to content

Add sync tests#64

Merged
MJGaughran merged 16 commits into
mainfrom
add-sync-tests
Jul 15, 2026
Merged

Add sync tests#64
MJGaughran merged 16 commits into
mainfrom
add-sync-tests

Conversation

@MJGaughran

Copy link
Copy Markdown
Contributor

These are the tests for code related to the sync command that aren't otherwise part of the golden master (lifecycle) tests.

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.84%. Comparing base (cf92113) to head (a00da36).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   85.80%   92.84%   +7.04%     
==========================================
  Files          27       27              
  Lines         979      979              
==========================================
+ Hits          840      909      +69     
+ Misses        139       70      -69     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ptsOSL
ptsOSL previously approved these changes Jul 10, 2026

@ptsOSL ptsOSL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a couple of comments, but I didn't see anything major. So Im just going to approve and leave it up to you to decide if you want to make changes based on my comments.

Comment thread tests/test_apptainer_pull.py
Comment thread tests/test_module_options.py Outdated
Comment thread tests/test_sync.py
Previously, all modules managed by the current Deployment required a
specific, pinned version if they were a dependency. This was then
relaxed, but docstrings and comments were left out of date.

@ptsOSL ptsOSL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MJGaughran MJGaughran merged commit b5e0754 into main Jul 15, 2026
11 checks passed
@MJGaughran MJGaughran deleted the add-sync-tests branch July 15, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants