Skip to content

fix(ios): preserve top position through initial loading - #2611

Merged
Tlaster merged 1 commit into
masterfrom
bugfix/ios-loading-bookmark-origin
Sep 30, 2026
Merged

Tlaster merged 1 commit into
masterfrom
bugfix/ios-loading-bookmark-origin

Conversation

@Tlaster

@Tlaster Tlaster commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Weibo detail could jump away from the top when comments or reposts finished loading because repeated initial-loading updates saved the placeholder-era tabs as a reload bookmark. Discover could also hide newly loaded user sections when an accessory measurement left an item bookmark that had actually been captured at the top.

Only capture reload bookmarks when entering loading from a non-loading snapshot. Record whether a layout bookmark originated at the top and carry that information into geometry changes, allowing late top sections to stay visible while preserving genuinely scrolled bookmarks through temporary offset clamping.

Validation on iPhone 17 Pro / iOS 26.5:

  • The two new controller tests and the strengthened layout-to-geometry test failed on master and pass with this change.
  • 28 controller regression tests, 39 native collection-view tests, and 2 diagnostic probes covering 14 initial-loading scenarios passed.
  • Tests ran in an isolated simulator host with current controller/collection sources and cached Kotlin/rendering modules. The list-renderer integration test was excluded because the cached module predates that API. Full current-app build and physical-device verification were not run.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Tlaster
Tlaster merged commit 45a6bb4 into master Sep 30, 2026
7 of 8 checks passed
@Tlaster
Tlaster deleted the bugfix/ios-loading-bookmark-origin branch September 30, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant