Repository navigation
Remove the dead activityJson field - #3030
Merged
Merged
Conversation
`activityJson` was declared on `QuestionBank` and `ProblemSet` and read by four loaders, but the API never populated it — every one of those loaders always took the `compileActivityFromContent` fallback. Git history shows why: it began as a client-side local, and a later PR added the "stored revision source" fallback shape and the type field without ever implementing the server half. Delete the field and collapse the four fallbacks. The loader result key of the same name is kept — that is the real compiled source — as is RawViewer's by-cid branch, which parses a genuinely stored revision source and whose `isActivitySource` guard is load-bearing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dqnykamp
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
activityJsonwas declared onQuestionBankandProblemSet, and four loaders read it. The API never populated it, so every one of those loaders always fell through tocompileActivityFromContentinstead.It appears to have started life as a client-side local. A later PR added the "stored revision source" fallback shape and the type field alongside it, but the server half that would have filled it in was never written.
This removes the field and collapses the four fallbacks down to the call that was already doing the work.
Two things that look similar are kept deliberately:
RawViewer's by-cid branch, which parses a genuinely stored revision source; itsisActivitySourceguard is load-bearingNo runtime change, since the deleted branch was unreachable.
tsc --noEmitpasses onapps/apiandapps/app.🤖 Generated with Claude Code
(Takes code from #3026)