Skip to content

fix: Use internet bitrate for mobile playback - #1086

Merged
PartyDonut merged 2 commits into
DonutWare:developfrom
Charlie284:fix/mobile-internet-bitrate
Aug 23, 2026
Merged

fix: Use internet bitrate for mobile playback#1086
PartyDonut merged 2 commits into
DonutWare:developfrom
Charlie284:fix/mobile-internet-bitrate

Conversation

@Charlie284

Copy link
Copy Markdown
Contributor

Summary

  • Select the home bitrate for Wi-Fi and Ethernet playback.
  • Select the internet bitrate for mobile and existing non-home connectivity states.
  • Add regression coverage for Auto, a fixed 10 Mbps mobile limit, and offline semantics.

The playback creation path always read maxHomeBitrate, even when connectivityStatusProvider reported mobile data. The selected connection-specific setting now feeds the same quality options used to build the Jellyfin playback request and subsequent reloads.

Fixes #1082

Testing

  • dart format test/playback_bitrate_helper_test.dart (no changes)
  • flutter analyze --no-pub with Flutter 3.35.7 (no issues)
  • flutter test --no-pub test/playback_bitrate_helper_test.dart test/pip_manager_test.dart (12 passed)
  • flutter test --no-pub (12 passed, 1 pre-existing failure in test/widget_test.dart; it mounts Main without a ProviderScope and still expects the removed counter UI)

@Charlie284
Charlie284 marked this pull request as ready for review August 13, 2026 01:59

@PartyDonut PartyDonut left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks for the fix. Removed the test, have to properly set that up sometime but for now lets leave them out.

@PartyDonut
PartyDonut merged commit 1ea9f13 into DonutWare:develop Aug 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internet quality bitrate is ignored; mobile playback always uses Home quality

2 participants