Skip to content

Surface skills paused for re-review #57

Description

@youngbrioche

When a skill changes after it was enabled for a room, exxperts correctly stops injecting it until the user reviews the current version. The security behavior makes sense, but the state change is easy to miss.

I only discovered by chance under Room settings → Skills that some skills needed re-review. Until then, the room had silently lost abilities I expected it to have. I couldn't find any indication on the room card, the settings gear, or inside the open room.

The behavior comes from apps/web-server/src/persistent-room-skill-settings.ts: effectiveEnabledSkills() excludes every hash-mismatch. The warning and “Review changes” action exist in apps/web-ui/src/components/RoomSkillsSection.tsx, but only after opening the room settings and selecting Skills.

Could affected rooms surface this state where the user will see it? For example:

  • a room-card or settings badge such as “2 skills need review”
  • a small notice when entering an affected room
  • a direct link to Room settings → Skills

The fail-closed behavior should stay. The missing part is making the paused skills visible, so a room does not appear fully configured while some of its expected abilities are inactive.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions