Skip to content

fix: lint - #655

Merged
Justin Hammond (Justintime50) merged 1 commit into
masterfrom
fix_lint
Apr 6, 2026
Merged

fix: lint#655
Justin Hammond (Justintime50) merged 1 commit into
masterfrom
fix_lint

Conversation

@Justintime50

Copy link
Copy Markdown
Member

Description

Fixes various warnings from lint that have been around awhile

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the warnings be done at the top level rather than in each file?

@Justintime50

Copy link
Copy Markdown
Member Author

Should the warnings be done at the top level rather than in each file?

For this one no, the warning we're ignoring is adding docstrings to properties. These 3ish files have properties that are undocumented so it makes sense to only ignore these ones.

@Justintime50
Justin Hammond (Justintime50) merged commit f334de6 into master Apr 6, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants