Repository navigation
Conversation
parseCrossChainPayment dropped the parser's metadata and legacyAddress. The tile's cross-chain accept path and detection's adoption in handleUnparsedAddress therefore took a gateway (<pluginId>://) or legacy address without the confirmations every same-chain path shows. CrossChainPayment now carries the payout's currencyCode, metadata and legacyAddress, and both cross-chain paths run addressWarnings before adopting. A declined warning adopts nothing and reports no invalid address.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical Design Document
stealth-send-swap.md
Description
Asana task
Follow-up to EdgeApp/edge-react-gui#6253, addressing its open security review thread on
src/util/paymentUri.ts.parseCrossChainPaymentdropped the parser'smetadataandlegacyAddress. A code for another network entered on the Send scene (through the address tile or detection inhandleUnparsedAddress) was therefore adopted without the gateway (<pluginId>://) and legacy-address confirmations that every same-chain path shows.CrossChainPaymentnow carries the payout asset'scurrencyCode,metadataandlegacyAddress, and both cross-chain paths calladdressWarningsbefore adopting the address. Declining a warning adopts nothing and shows no invalid-address error.Tests:
paymentUri.test.tscovers the carried fields;SendScene2.recipientNetwork.ui.test.tsxand a newAddressTile2suite cover decline (nothing adopted) and accept. Both decline tests fail with the twoaddressWarningscalls removed. On the iOS sim, enteringethereum://0x...from a BTC Send shows the ETH gateway warning; declining keeps the recipient empty, and accepting adopts the address with the network-changed toast.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Test evidence
73d7407Warn on cross-chain gateway and legacy codes
2026-10-24
1. eth gateway warning on btc send
2. declined recipient stays empty
3. accepted address adopted on ethereum