Fix/setting - #532
Merged
Merged
Conversation
Optimization(zh-Hant): 資料頁卡片改為橫式排版，一眼看完更清楚 Optimization(en-US): the data hub cards are compact and easier to scan
New(zh-Hant): 常用地區下方新增說明，通知以 GPS 位置發送，常用地區僅影響首頁顯示 New(en-US): saved regions now carry a note that alerts follow GPS, not the saved list
|
🔍 OpenCodeReview found 4 issue(s) in this PR.
📄
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+204
to
265
| return DecoratedBox( | ||
| decoration: BoxDecoration( | ||
| borderRadius: AppRadius.large, | ||
| gradient: LinearGradient( | ||
| begin: Alignment.topLeft, | ||
| end: Alignment.bottomRight, | ||
| colors: [ | ||
| colors.primary, | ||
| Color.lerp(colors.primary, colors.surface, 0.72)!, | ||
| ], | ||
| ), | ||
| ), | ||
| child: Material( | ||
| type: MaterialType.transparency, | ||
| child: InkWell( | ||
| borderRadius: AppRadius.large, | ||
| onTap: onTap, | ||
| child: Padding( | ||
| padding: const EdgeInsets.symmetric( | ||
| horizontal: AppSpacing.lg, | ||
| vertical: AppSpacing.md, | ||
| ), | ||
| child: Row( | ||
| children: [ | ||
| Container( | ||
| padding: const EdgeInsets.all(AppSpacing.sm), | ||
| decoration: BoxDecoration( | ||
| color: colors.onPrimary.withValues(alpha: 0.18), | ||
| borderRadius: AppRadius.medium, | ||
| ), | ||
| child: Icon(icon, color: colors.onPrimary), | ||
| ), | ||
| child: Icon(icon, color: colors.onSecondaryContainer), | ||
| ), | ||
| const SizedBox(width: AppSpacing.lg), | ||
| Expanded( | ||
| child: Column( | ||
| crossAxisAlignment: CrossAxisAlignment.start, | ||
| children: [ | ||
| Text( | ||
| title, | ||
| style: Theme.of(context).textTheme.titleMedium?.copyWith( | ||
| color: colors.onPrimaryContainer, | ||
| fontWeight: FontWeight.w700, | ||
| const SizedBox(width: AppSpacing.lg), | ||
| Expanded( | ||
| child: Column( | ||
| crossAxisAlignment: CrossAxisAlignment.start, | ||
| children: [ | ||
| Text( | ||
| title, | ||
| style: Theme.of(context).textTheme.titleMedium | ||
| ?.copyWith( | ||
| color: colors.onPrimary, | ||
| fontWeight: FontWeight.w700, | ||
| ), | ||
| ), | ||
| ), | ||
| const SizedBox(height: AppSpacing.xs), | ||
| Text( | ||
| subtitle, | ||
| style: Theme.of(context).textTheme.bodySmall?.copyWith( | ||
| color: colors.onPrimaryContainer.withValues(alpha: 0.8), | ||
| const SizedBox(height: AppSpacing.xs), | ||
| Text( | ||
| subtitle, | ||
| style: Theme.of(context).textTheme.bodySmall?.copyWith( | ||
| color: colors.onPrimary.withValues(alpha: 0.78), | ||
| ), | ||
| ), | ||
| ), | ||
| ], | ||
| ], | ||
| ), | ||
| ), | ||
| ), | ||
| Icon(Icons.chevron_right, color: colors.onPrimaryContainer), | ||
| ], | ||
| Icon(Icons.chevron_right, color: colors.onPrimary), | ||
| ], | ||
| ), | ||
| ), | ||
| ), | ||
| ), | ||
| ); |
There was a problem hiding this comment.
_SeismicCard 的色彩對比度與可讀性風險。新的設計使用了 LinearGradient（由 primary 色向 surface 色漸變）作為背景，並將文字顏色設為 onPrimary。在特定的主題配置下（例如當 primary 與 surface 色值較接近時），這種漸層背景可能會降低緊急資訊（Seismic data）的可讀性，不符合無障礙設計原則。建議確保漸層兩端的色值與 onPrimary 文字之間保有足夠的對比度。
Comment on lines
+1
to
2
| /// Lists the currently saved townships with a remove action, and an **add** | ||
| library; |
There was a problem hiding this comment.
檔案層級的文檔註釋 (第 1 行) 不完整，且內容似乎是將類別層級的註釋 (第 15-16 行) 複製過來後被截斷了。建議修正為完整的描述或將其刪除。
Comment on lines
+2119
to
+2121
| @override | ||
| String get regionSaveNote => | ||
| 'Ipapadala ang mga abiso batay sa iyong lokasyon ng GPS. Ang pag-set ng paboritong lugar ay hindi nagbabago kung saan ipinapadala ang alerto — ang mga paboritong lugar ay para lang mabilis mong makita ang kalagayan ng bawat lugar sa home. Ibigay ang pahintulot sa lokasyon, kung hindi hindi gagana ang mga abiso.'; |
There was a problem hiding this comment.
此檔案位於 gen/ 目錄下，通常是由工具自動生成的。直接修改此檔案可能導致您的變更在下次執行生成指令時被覆蓋。建議將翻譯內容新增至原始的 .arb 檔案（例如 lib/l10n/app_fil.arb），然後重新生成程式碼。此外，建議統一使用 "rehiyon" (region) 而非 "lugar" (place) 以保持術語一致性。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
這個 PR 做了什麼
相關 issue
怎麼驗
檢查清單
tool/check_commits.sh origin/main..HEAD通過—— commit 訊息就是更新日誌，格式見 commit.md
mise exec -- flutter analyze與mise exec -- flutter test通過AppLocalizations，沒有寫死AppSpacing/AppRadius/AppMotion，深色模式看過，文字對比度可接受