-
-
Notifications
You must be signed in to change notification settings - Fork 22
Fix/version week #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
whes1015
wants to merge
11
commits into
main
Choose a base branch
from
fix/version-week
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/version week #533
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
78e596f
fix: name a build for the week Taipei is in, not the week UTC is in
whes1015 2aed84c
feat(settings): row-align the sponsor card with the hero stack
whes1015 eb1a6f9
build: stamp the last release into every build
whes1015 8b20b93
feat(settings): rework the More hero cards, flat and number-led
whes1015 e5430ca
fix(map): show timeline labels in the device's local time
whes1015 5e38527
refactor(build): feed the version card its train, not the last release
whes1015 e3f2864
fix(settings): align the three hero-card rows on the same left edge
whes1015 6730fb7
feat(settings): lead the version card with the train number
whes1015 68ddee6
feat(settings): fold the server-status card into the hero stack
whes1015 9294bc7
feat(settings): always print a fine-print version line on the hero card
whes1015 3b26f51
feat(build): let a release's train drop its patch
whes1015 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,18 @@ | ||
| // GENERATED — do not edit by hand. Written by tool/gen_build_info.sh (run by the | ||
| // git hooks in .githooks/; set up once with tool/setup.sh). Holds what git knows | ||
| // about this build, so a debug build can name itself without CI's --dart-define. | ||
| // | ||
| // What is *committed* here is a stub, on purpose. The file is `skip-worktree` | ||
| // locally so a regenerated copy never dirties the tree — which also means a | ||
| // real value written here would be frozen at whoever last cleared that flag, | ||
| // and a clone that has not run tool/setup.sh would confidently report someone | ||
| // else's build. Empty values fall back to the platform's own version instead. | ||
| library; | ||
|
|
||
| /// Short git commit hash of HEAD at generation time ('unknown' outside a repo). | ||
| const String kGitCommit = 'unknown'; | ||
| const String kGitCommit = '31da8b50'; | ||
|
|
||
| /// The label tool/version.sh derives for HEAD — '26w33b', '26.1'. Empty when | ||
| /// git could not answer, in which case the platform's own version is used. | ||
| const String kBuildLabel = ''; | ||
| const String kBuildLabel = '26w34a'; | ||
|
|
||
| /// The ordinal that goes with it; 0 when git could not answer. | ||
| const int kBuildCode = 0; | ||
| const int kBuildCode = 426000335; | ||
|
|
||
| /// The train number version.sh derives — '26.1'. Apple is told this and | ||
| /// never the label; the More page version card shows it as the big number. | ||
| const String kBuildTrain = '26.1'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ensureLoaded方法目前的冪等性檢查依賴於_label != null。如果_bestLabel為空或_bestCode不大於 0(例如在某些開發環境下),_label將保持為null,導致每次呼叫ensureLoaded都會重新執行非同步的PackageInfo.fromPlatform()。建議使用一個獨立的布林值(如_isLoaded)來標記載入狀態,以避免重複的 IO 操作。Suggestion: